Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo name no updated in project after being changed #286

Closed
AntiD2ta opened this issue Dec 16, 2019 · 1 comment · Fixed by #287 or #300
Closed

Repo name no updated in project after being changed #286

AntiD2ta opened this issue Dec 16, 2019 · 1 comment · Fixed by #287 or #300
Assignees
@AntiD2ta
Labels
bug Something isn't working stdev
Projects
FiberCrypto wallet - Iteration 1
Milestone
0.27.0

Comments

@AntiD2ta
Copy link
Contributor

Describe the bug
The repository name was changed and references to it were not updated, this causes some errors.

Steps to Reproduce

  1. Run grep -nr "FiberCryptoWallet" in the cli from the project's root directory
  2. You should see severals matches.

Actual behavior
Currently, the wallet can't be opened in Linux nor Windows environment because the makefile is not updated.

Expected behavior
All should work as before changing the name.

Possible implementation
Replace FiberCryptoWallet for fibercryptowallet in code.
@AntiD2ta AntiD2ta added the bug Something isn't working label Dec 16, 2019
@AntiD2ta AntiD2ta added this to the 0.27.0 milestone Dec 16, 2019
@AntiD2ta AntiD2ta self-assigned this Dec 16, 2019
@AntiD2ta AntiD2ta added this to To do in FiberCrypto wallet - Iteration 1 via automation Dec 16, 2019
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Dec 16, 2019
@AntiD2ta
refs fibercrypto#286 - Replace "FiberCryptoWallet" for "fibercryptowa…
46be813 
…llet" properly

Files changed:
-  .travis.yml
- CONTRIBUTING.md
- Makefile
- README.md

FiberCryptoWallet matches when used as app name were not modified
@AntiD2ta AntiD2ta changed the title Repo name no updated in project after being change Repo name no updated in project after being changed Dec 16, 2019
@AntiD2ta AntiD2ta added the stdev label Dec 16, 2019
@AntiD2ta AntiD2ta mentioned this issue Dec 16, 2019
Merged
@olemis
Copy link
Contributor

olemis commented Dec 16, 2019

@stdevAntiD2ta is there a PR I can review for this ?

FiberCrypto wallet - Iteration 1 automation moved this from To do to Done Dec 17, 2019
olemis added a commit that referenced this issue Dec 17, 2019
@olemis
Merge pull request #287 from simelo/stdevAntiD2ta_t286_Update_repo_na…
961d1a0 
…me_in_code

Fixes #286 - Repository name updated properly in project
@AntiD2ta AntiD2ta reopened this Dec 24, 2019
FiberCrypto wallet - Iteration 1 automation moved this from Done to In progress Dec 24, 2019
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Dec 24, 2019
@AntiD2ta
refs fibercrypto#286 - Replace "FiberCryptoWallet" for "fibercryptowa…
2998104 
…llet" properl
@AntiD2ta AntiD2ta mentioned this issue Dec 24, 2019
Merged
FiberCrypto wallet - Iteration 1 automation moved this from In progress to Done Jan 3, 2020
stdevMac added a commit that referenced this issue Jan 3, 2020
@stdevMac
Merge pull request #300 from simelo/stdevAntiD2ta_t286_Update_repo_na…
2423029 
…me_in_code

Fixes #286 - Repository name updated properly in project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntiD2ta AntiD2ta

Labels
bug Something isn't working stdev
Projects
FiberCrypto wallet - Iteration 1
  
Done
Milestone
0.27.0
2 participants
@olemis @AntiD2ta