-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #142 Configure golang-ci and run it in Travis builds #165
Merged
stdevMac
merged 23 commits into
fibercrypto:develop
from
simelo:stdevHan_t142_make_lint
Oct 16, 2019
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
28e4854
[Makefile] refs #142 Added target to call sentence `make lint`
ec48814
[travis] refs #142 Added file to conf golangci
7eb6363
[travis] refs #142 Added `make lint ` in `script`
0a10d68
[Makefile] refs #142 Added target `make install-linters`
434e93b
[Travis] refs #142 Added in step in matrix `make install-linters`
17261f8
[Makefile] refs #142 Enable only checking `make lint golangci-lint`
eaa88a2
[Makefile] refs #142 Added in travis vendorcheck ./...
024283c
[vendor] refs #142 Tryninng vendor
796afc5
[vendor] refs #142 Remove vendor
af37462
[gitignire] refs #142 Restore conf
b452fb4
refs #142 Merge branch 'develop' of https://github.com/fibercrypto/F…
9f80473
[src] refs #142 FInalized `src/coin` , `src/core`, `src/util` and `sr…
c123e77
refs #142 Merge branch 'develop' of https://github.com/fibercrypto/Fi…
241d68b
[coin] refs #142 Correcting error the linter in coin
cfe7da4
[TravisCI] refs #142 Added suite test `make lint`
8f3812c
[models] refs #142 Added true path the ENV params in `walletsManager`
3b1c63e
[TravisCI] refs #142 Added install the `golangci` in Windows
eac3692
[TravisCI] refs #142 Correcting the order of the steps for the instal…
b457ea8
[travis] refs #142 Added in script the golangci-lint support to Windows
efdf374
[TravisCi] refs #142 Correcting declare `golangci-lint` in Win
890e3d7
[TravisCI] refs #142 Added support make lint in Windows
6febcc1
[coin] refs #142 Disable false positive
02713c0
[TravisCI] refs #142 Correcting used golangci-lint for Windows
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,188 @@ | ||
# This file contains all available configuration options | ||
# Modified for linting src/ | ||
|
||
# options for analysis running | ||
run: | ||
# default concurrency is a available CPU number | ||
concurrency: 4 | ||
|
||
# timeout for analysis, e.g. 30s, 5m, default is 1m | ||
deadline: 15m | ||
|
||
# exit code when at least one issue was found, default is 1 | ||
issues-exit-code: 1 | ||
|
||
# include test files or not, default is true | ||
tests: true | ||
|
||
# list of build tags, all linters use it. Default is empty list. | ||
build-tags: | ||
|
||
# which dirs to skip: they won't be analyzed; | ||
# can use regexp here: generated.*, regexp is applied on full path; | ||
# default value is empty list, but next dirs are always skipped independently | ||
# from this option's value: | ||
# vendor$, third_party$, testdata$, examples$, Godeps$, builtin$ | ||
skip-dirs: | ||
- /usr/local/go/src | ||
|
||
# which files to skip: they will be analyzed, but issues from them | ||
# won't be reported. Default value is empty list, but there is | ||
# no need to include all autogenerated files, we confidently recognize | ||
# autogenerated files. If it's not please let us know. | ||
skip-files: | ||
|
||
|
||
# output configuration options | ||
output: | ||
# colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number" | ||
format: colored-line-number | ||
|
||
# print lines of code with issue, default is true | ||
print-issued-lines: true | ||
|
||
# print linter name in the end of issue text, default is true | ||
print-linter-name: true | ||
|
||
|
||
# all available settings of specific linters | ||
linters-settings: | ||
errcheck: | ||
# report about not checking of errors in type assetions: `a := b.(MyStruct)`; | ||
# default is false: such cases aren't reported by default. | ||
check-type-assertions: false | ||
|
||
# report about assignment of errors to blank identifier: `num, _ := strconv.Atoi(numStr)`; | ||
# default is false: such cases aren't reported by default. | ||
check-blank: true | ||
govet: | ||
# report about shadowed variables | ||
check-shadowing: true | ||
|
||
# Obtain type information from installed (to $GOPATH/pkg) package files: | ||
# golangci-lint will execute `go install -i` and `go test -i` for analyzed packages | ||
# before analyzing them. | ||
# By default this option is disabled and govet gets type information by loader from source code. | ||
# Loading from source code is slow, but it's done only once for all linters. | ||
# Go-installing of packages first time is much slower than loading them from source code, | ||
# therefore this option is disabled by default. | ||
# But repeated installation is fast in go >= 1.10 because of build caching. | ||
# Enable this option only if all conditions are met: | ||
# 1. you use only "fast" linters (--fast e.g.): no program loading occurs | ||
# 2. you use go >= 1.10 | ||
# 3. you do repeated runs (false for CI) or cache $GOPATH/pkg or `go env GOCACHE` dir in CI. | ||
use-installed-packages: false | ||
golint: | ||
# minimal confidence for issues, default is 0.8 | ||
min-confidence: 0.8 | ||
gofmt: | ||
# simplify code: gofmt with `-s` option, true by default | ||
simplify: true | ||
gocyclo: | ||
# minimal code complexity to report, 30 by default (but we recommend 10-20) | ||
min-complexity: 10 | ||
maligned: | ||
# print struct with more effective memory layout or not, false by default | ||
suggest-new: true | ||
dupl: | ||
# tokens count to trigger issue, 150 by default | ||
threshold: 100 | ||
goconst: | ||
# minimal length of string constant, 3 by default | ||
min-len: 3 | ||
# minimal occurrences count to trigger, 3 by default | ||
min-occurrences: 3 | ||
depguard: | ||
list-type: blacklist | ||
include-go-root: false | ||
packages: | ||
- github.com/pkg/errors | ||
misspell: | ||
# Correct spellings using locale preferences for US or UK. | ||
# Default is to use a neutral variety of English. | ||
# Setting locale to US will correct the British spelling of 'colour' to 'color'. | ||
locale: US | ||
lll: | ||
# max line length, lines longer will be reported. Default is 120. | ||
# '\t' is counted as 1 character by default, and can be changed with the tab-width option | ||
line-length: 120 | ||
# tab width in spaces. Default to 1. | ||
tab-width: 1 | ||
unused: | ||
# treat code as a program (not a library) and report unused exported identifiers; default is false. | ||
# XXX: if you enable this setting, unused will report a lot of false-positives in text editors: | ||
# if it's called for subdir of a project it can't find funcs usages. All text editor integrations | ||
# with golangci-lint call it on a directory with the changed file. | ||
check-exported: false | ||
unparam: | ||
# call graph construction algorithm (cha, rta). In general, use cha for libraries, | ||
# and rta for programs with main packages. Default is cha. | ||
algo: cha | ||
|
||
# Inspect exported functions, default is false. Set to true if no external program/library imports your code. | ||
# XXX: if you enable this setting, unparam will report a lot of false-positives in text editors: | ||
# if it's called for subdir of a project it can't find external interfaces. All text editor integrations | ||
# with golangci-lint call it on a directory with the changed file. | ||
check-exported: false | ||
nakedret: | ||
# make an issue if func has more lines of code than this setting and it has naked returns; default is 30 | ||
max-func-lines: 30 | ||
prealloc: | ||
# XXX: we don't recommend using this linter before doing performance profiling. | ||
# For most programs usage of prealloc will be a premature optimization. | ||
|
||
# Report preallocation suggestions only on simple loops that have no returns/breaks/continues/gotos in them. | ||
# True by default. | ||
simple: true | ||
range-loops: true # Report preallocation suggestions on range loops, true by default | ||
for-loops: false # Report preallocation suggestions on for loops, false by default | ||
|
||
|
||
linters: | ||
enable: | ||
- varcheck | ||
- unparam | ||
- structcheck | ||
- errcheck | ||
- gosimple | ||
- staticcheck | ||
- unused | ||
- ineffassign | ||
- typecheck | ||
- gosec | ||
- megacheck | ||
- misspell | ||
- depguard | ||
enable-all: false | ||
disable: | ||
disable-all: true | ||
presets: | ||
fast: false | ||
|
||
|
||
issues: | ||
# List of regexps of issue texts to exclude, empty list by default. | ||
# But independently from this option we use default exclude patterns, | ||
# it can be disabled by `exclude-use-default: false`. To list all | ||
# excluded by default patterns execute `golangci-lint run --help` | ||
exclude: | ||
|
||
# Independently from option `exclude` we use default exclude patterns, | ||
# it can be disabled by this option. To list all | ||
# excluded by default patterns execute `golangci-lint run --help`. | ||
# Default value for this option is true. | ||
exclude-use-default: false | ||
|
||
# Maximum issues count per one linter. Set to 0 to disable. Default is 50. | ||
max-per-linter: 0 | ||
|
||
# Maximum count of issues with the same text. Set to 0 to disable. Default is 3. | ||
max-same: 0 | ||
|
||
# Show only new issues: if there are unstaged changes or untracked files, | ||
# only those changes are analyzed, else only changes in HEAD~ are analyzed. | ||
# It's a super-useful option for integration of golangci-lint into existing | ||
# large codebase. It's not practical to fix all existing issues at the moment | ||
# of integration: much better don't allow issues in new code. | ||
# Default is false. | ||
new: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stdevHan is possible to use a env var here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not tried it before, I will review