refs #279 Improve coverage #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pending: - Find how to register skycoin coins without import the skycoin package, import it produces cyclic imports
…Password Note: - TestPassword cover both funtions
Remove negativity verification inside the function. uint64 can not be negative
Pendig: - `GetCoinValue` - `AddressFromString` - Both need some previously registered coins
…test for NewGenericOutput
Changes: - `SkycoinUninjectedTransaction.ComputeFee(...)` method report invalid ticker error when the ticker in not supported - `SkycoinCreatedTransactionInput.GetSpentOutput()` was calling `GetCoin(...)` with an invalid argument, know use the correct one - `TestWalletsListAssets` modified
… into stdevRulo_t279_improve_coverage
olemis
requested changes
Jan 6, 2020
modified: src/coin/mocks/Address.go modified: src/coin/mocks/AltcoinPlugin.go new file: src/coin/mocks/PubKey.go new file: src/coin/mocks/SecKey.go modified: src/coin/mocks/WalletSet.go
…estWalletNodeGetStorage`
- `TestSeedServiceGenerateMnemonic` - `TestSeedServiceVerifyMnemonic`
…estWalletFunctions` Changes: - Test `RemoteWallet` functions too
…`TestSkyFiberPluginFunctions`
Changes: - Include `Params` verification - Include `LoadSignService` method test
…omBytes` and `SecKeyFromBytes`
… and `TestSkyFiberPluginSecKeyFromBytes`
ineffectual assignment
more internal paths covered by tests
…tion and use `mockery` to generate it instead
All testable internal paths covered
100% covered
…profile and merge with coverage output
…ycoin repository
…t => SkycoinProject/skycoin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #279
Changes:
Does this change need to mentioned in CHANGELOG.md?
no
Requires testing
no