juice, refactor: reset fingerprint in remote description when disable…

…FingerprintVerification.
fibjs · May 19, 2024 · bc4aec8 · bc4aec8
1 parent 67bce3d
commit bc4aec8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/datachannel/src/impl/peerconnection.cpp b/datachannel/src/impl/peerconnection.cpp
@@ -429,13 +429,20 @@ void PeerConnection::rollbackLocalDescription() {
 	}
 }
 
-bool PeerConnection::checkFingerprint(const std::string &fingerprint) const {
+bool PeerConnection::checkFingerprint(const std::string &fingerprint) {
 	std::lock_guard lock(mRemoteDescriptionMutex);
 	if (!mRemoteDescription || !mRemoteDescription->fingerprint())
 		return false;
 
-	if (config.disableFingerprintVerification)
+	if (config.disableFingerprintVerification) {
+		CertificateFingerprint fp;
+
+		fp.algorithm = mRemoteDescription->fingerprint()->algorithm;
+		fp.value = fingerprint;
+		mRemoteDescription->setFingerprint(fp);
+
 		return true;
+	}
 
 	auto expectedFingerprint = mRemoteDescription->fingerprint()->value;
 	if (expectedFingerprint  == fingerprint) {

diff --git a/datachannel/src/impl/peerconnection.hpp b/datachannel/src/impl/peerconnection.hpp
@@ -53,7 +53,7 @@ struct PeerConnection : std::enable_shared_from_this<PeerConnection> {
 
 	void endLocalCandidates();
 	void rollbackLocalDescription();
-	bool checkFingerprint(const std::string &fingerprint) const;
+	bool checkFingerprint(const std::string &fingerprint);
 	void forwardMessage(message_ptr message);
 	void forwardMedia(message_ptr message);
 	void forwardBufferedAmount(uint16_t stream, size_t amount);