Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are the projects divided into opened and closed when the same value is saved in the entries' "action" anyway? #30

Closed
FichteFoll opened this issue Sep 30, 2014 · 4 comments
Labels
Milestone

Comments

@FichteFoll
Copy link
Owner

I think this is a relict of the past since the only thing that happens with them currently is that both lists are joined in get_history and that's it.

In the light of #28 it makes sense to combine both data file restructurings at the same time (for the same release.

@jbjornson, let me know what you think and I'll do it, or you do it yourself. Just let me take care of releasing.

@FichteFoll FichteFoll added this to the 1.7.0 milestone Sep 30, 2014
@jbjornson
Copy link
Collaborator

The open and closed lists are separated basically for sorting purposes. The main purpose of the plugin is to provide better access to the files that have been closed, and these files should be first in the quick panel list and by chronological order. I think this is important. The opened files basically provide quick access to the files that you have open and should be at the end of the quick panel list.

I guess we could append the opened files to the end of the list, but then it is more difficult to discard the old history entries when the list starts getting large (see settings global_max_entries and project_max_entries). Keeping the lists separate makes sorting and list size maintenance simple and combining them is also easy.

Personally I would like to keep it the way it is.

@FichteFoll FichteFoll added question and removed task labels Sep 30, 2014
@FichteFoll
Copy link
Owner Author

Okay, if that's what it's supposed to do (list opened after closed) then it's okay since it makes it easier to work with the separate lists. For some reason I never really understood why opened files were saved at all but the most practical usecase seems to be when working with multiple projects.

However, we can remove the action key in this case.

@jbjornson
Copy link
Collaborator

We use the action key in the quick panel to show whether the user opened or closed that file last. If we remove this key then we lose the context (opened or closed) when we combine the two lists together.

Yes, the opened files are very helpful when working on multiple projects.

@FichteFoll
Copy link
Owner Author

Pushed changes to no_action_key branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants