Skip to content

Commit

Permalink
fix: unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
arpowers committed Apr 4, 2024
1 parent 58dd6d8 commit 603d798
Show file tree
Hide file tree
Showing 17 changed files with 39 additions and 31 deletions.
3 changes: 2 additions & 1 deletion @fiction/core/utils/test/nodeTools.ci.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('node utils', () => {

expect(Object.keys(service).sort()).toMatchInlineSnapshot(`
[
"fictionAdmin",
"fictionAi",
"fictionApp",
"fictionAppSites",
"fictionAws",
Expand All @@ -66,6 +66,7 @@ describe('node utils', () => {
"fictionRouter",
"fictionRouterSites",
"fictionServer",
"fictionSites",
"fictionTeam",
"fictionUi",
"fictionUser",
Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/el/InputAi.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import ElForm from '@fiction/ui/ElForm.vue'
import ElButton from '@fiction/ui/ElButton.vue'
import InputText from '@fiction/ui/InputText.vue'
import InputCheckbox from '@fiction/ui/InputCheckbox.vue'
import type { Site } from '@fiction/site'
import type { InputOptionGeneration } from '@fiction/ui'
import TransitionSlide from '@fiction/ui/TransitionSlide.vue'
import ElModal from '@fiction/ui/ElModal.vue'
import ElProgress from '@fiction/ui/ElProgress.vue'
import type { Site } from '../site'
const props = defineProps({
modelValue: { type: String, default: '' },
Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/el/fig/FigSite.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script lang='ts' setup>
import type { Site } from '@fiction/site/site'
import type { vue } from '@fiction/core'
import ElBrowserFrameDevice from '@fiction/ui/ElBrowserFrameDevice.vue'
import type { Site } from '../../../site'
import FigSite from './img/figSite.svg'
import FigSiteMobile from './img/figSiteMobile.svg'
Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export class FictionSites extends FictionPlugin<SitesPluginSettings> {
const finalSelectorType = selectorType || (siteId ? 'site' : subDomain ? 'domain' : themeId ? 'theme' : 'none')
const finalSelectorId = selectorId || siteId || subDomain || themeId || 'none'

return `${this.settings.adminBaseRoute}/preview/${finalSelectorType}/${finalSelectorId}`
return `${this.adminBaseRoute}/preview/${finalSelectorType}/${finalSelectorId}`
})
}
}
Expand Down
5 changes: 5 additions & 0 deletions @fiction/site/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
"tailwindcss": "^3.4.3",
"vue": "^3.4.21"
},
"devDependencies": {
"@fiction/theme-admin": "workspace:*",
"@fiction/theme-fiction": "workspace:*",
"@fiction/theme-minimal": "workspace:*"
},
"gitHead": "b257411e1c6c32b52b444cc6f1518bf1bee1e480",
"license": "GPL-2.0-only",
"main": "index.ts",
Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/routes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export function getRoutes(args: SitesQuerySettings) {
return [
new AppRoute({
name: `sitePreview`,
path: `${args.fictionSites.settings.adminBaseRoute}/preview/:selectorType/:selectorId/:viewId?/:itemId?`,
path: `${args.fictionSites.adminBaseRoute}/preview/:selectorType/:selectorId/:viewId?/:itemId?`,
component: () => import('./el/ViewPreview.vue'),
priority: 20,
}),
Expand Down
6 changes: 3 additions & 3 deletions @fiction/site/test/cert.ci.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { createSiteTestUtils } from './siteTestUtils'
let testUtils: SiteTestUtils
describe('manageCertificates', () => {
const hostname = 'example.com'
const maskedKeys = ['id', 'dnsValidationInstructions', 'dnsValidationTarget']
const maskedKeys = ['id', 'dnsValidationInstructions', 'dnsValidationTarget', 'issued', 'nodes']
beforeAll(async () => {
testUtils = createSiteTestUtils()
await testUtils.init()
Expand Down Expand Up @@ -38,7 +38,7 @@ describe('manageCertificates', () => {
"hostname": "test-site.fiction.cx",
"id": "**MASKED**",
"issued": {
"nodes": "[object Object],[object Object]",
"nodes": "**MASKED**",
},
"source": "fly",
}
Expand Down Expand Up @@ -102,7 +102,7 @@ describe('manageCertificates', () => {
"hostname": "example.com",
"id": "**MASKED**",
"issued": {
"nodes": "",
"nodes": "**MASKED**",
},
"source": "fly",
}
Expand Down
4 changes: 2 additions & 2 deletions @fiction/site/test/load.ci.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ describe('site plugin tests', async () => {

it('should load a site by themeId', async (ctx) => {
const themeId = 'test'
await testUtils.fictionRouter.push(`${testUtils.fictionSites.settings.adminBaseRoute}/preview/theme/${themeId}/`, { caller: ctx.task.name })
await testUtils.fictionRouter.push(`${testUtils.fictionSites.adminBaseRoute}/preview/theme/${themeId}/`, { caller: ctx.task.name })

const { selectorType, selectorId } = testUtils.fictionRouter.params.value as Record<string, string>
const mountContext = getMountContext({ selectorType, selectorId, siteMode: 'standard' })
Expand All @@ -299,7 +299,7 @@ describe('site plugin tests', async () => {

it('should load a site by siteId extracted from URL', async (ctx) => {
const siteId = site.siteId
await testUtils.fictionRouter.push(`${testUtils.fictionSites.settings.adminBaseRoute}/preview/site/${siteId}/`, { caller: ctx.task.name })
await testUtils.fictionRouter.push(`${testUtils.fictionSites.adminBaseRoute}/preview/site/${siteId}/`, { caller: ctx.task.name })

const { selectorType, selectorId } = testUtils.fictionRouter.params.value as Record<string, string>
const mountContext = getMountContext({ selectorType, selectorId, siteMode: 'standard' })
Expand Down
18 changes: 9 additions & 9 deletions @fiction/site/test/preview.ci.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@ describe('sitePreview', async () => {
const cur = () => r.current.value
const previewPath = () => testUtils.fictionSites.getPreviewPath().value

const orgBase = testUtils.fictionAdmin.adminBaseOrgPath.value
const orgBase = testUtils.fictionSites.adminBaseRoute
const siteEdit = `${orgBase}/siteEdit`

await r.push(`/admin/preview/theme/minimal`, { caller: ctx.task.name })
await r.push(`/admin/preview/theme/test`, { caller: ctx.task.name })

expect(cur().params).toMatchInlineSnapshot(`
{
"itemId": "",
"selectorId": "minimal",
"selectorId": "test",
"selectorType": "theme",
"viewId": "",
}
Expand All @@ -63,15 +63,15 @@ describe('sitePreview', async () => {

expect(previewPath()).toMatchInlineSnapshot(`"/admin/preview/site/554433"`)

await r.push(`${siteEdit}?themeId=minimal`, { caller: ctx.task.name })
await r.push(`${siteEdit}?themeId=test`, { caller: ctx.task.name })

expect(cur().query).toMatchInlineSnapshot(`
{
"themeId": "minimal",
"themeId": "test",
}
`)

expect(previewPath()).toMatchInlineSnapshot(`"/admin/preview/theme/minimal"`)
expect(previewPath()).toMatchInlineSnapshot(`"/admin/preview/theme/test"`)

await r.push(`${siteEdit}?subDomain=test-sub-domain`, { caller: ctx.task.name })

Expand Down Expand Up @@ -99,7 +99,7 @@ describe('sitePreview', async () => {
const result = await requestManageSite(
{
_action: 'create',
fields: { title: 'test', themeId: 'minimal', subDomain },
fields: { title: 'test', themeId: 'test', subDomain },
caller: ctx.task.name,
...common,
},
Expand All @@ -115,15 +115,15 @@ describe('sitePreview', async () => {

const html = await snapshotHtml(mountEl.innerHTML, { hideTags: ['svg'], maskIds: false })

expect(html).toContain('data-theme-id="minimal"')
expect(html).toContain('data-theme-id="test"')
expect(html).toContain(`data-site-id="${site?.siteId}"`)

await r.push(`/admin/preview/domain/${site?.subDomain.value}`, { caller: ctx.task.name })

await waitFor(300)

const html2 = await snapshotHtml(mountEl.innerHTML, { hideTags: ['svg'], maskIds: false })
expect(html2).toContain('data-theme-id="minimal"')
expect(html2).toContain('data-theme-id="test"')
expect(html2).toContain(`data-site-id="${site?.siteId}"`)
expect(html2).toContain(`data-sub-domain="${site?.subDomain.value}"`)
}, 10000)
Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/test/siteRequest.ci.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('siteLoading', async () => {

const subDomain = shortId()
const title = 'test'
const themeId = 'fiction'
const themeId = 'test'

const result = await requestManageSite(
{
Expand Down
4 changes: 2 additions & 2 deletions @fiction/site/test/siteTestUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type { FictionAdmin } from '@fiction/plugin-admin'
import { testEnvFile } from '@fiction/core/test-utils'
import { FictionSites } from '..'
import FSite from '../engine/FSite.vue'
import { setup as testThemeSetup } from './test-theme'
import * as testTheme from './test-theme'

export type SiteTestUtils = TestUtils & {
fictionAdmin: FictionAdmin
Expand Down Expand Up @@ -62,7 +62,7 @@ export function createSiteTestUtils(args: { mainFilePath?: string, context?: 'no
localHostname: '*.lan.com',
})

out.fictionSites = new FictionSites({ ...(out as SiteTestUtils), flyIoApiToken, flyIoAppId, themes: [testThemeSetup(out)] })
out.fictionSites = new FictionSites({ ...(out as SiteTestUtils), flyIoApiToken, flyIoAppId, themes: [testTheme.setup(out)] })

out.fictionEnv.log.info('sites test utils created')

Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/utils/frame.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export class SiteFrameTools extends FictionObject<SiteFrameUtilityParams> {
}

previewFrameUrl = vue.computed(() => {
const s = this.site.fictionSites.settings
const s = this.site.fictionSites
return `${s.adminBaseRoute}/preview/site/${this.site.siteId}${this.framePath.value}`
})

Expand Down
3 changes: 2 additions & 1 deletion @fiction/site/utils/test/frame.ci.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ describe('previewUrl', async () => {
it('should return the preview URL for the site', async () => {
const site = new Site({ ...common, isProd: true, subDomain: 'sub' })

expect(site.frame.previewFrameUrl.value).toBe(`${site.fictionSites.settings.adminBaseRoute}/preview/site/${site.siteId}`)
expect(site.fictionSites.adminBaseRoute).toMatchInlineSnapshot(`"/admin"`)
expect(site.frame.previewFrameUrl.value).toBe(`${site.fictionSites.adminBaseRoute}/preview/site/${site.siteId}`)
})
})

Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/utils/test/layout.ci.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import { beforeAll, describe, expect, it } from 'vitest'
import { JSDOM } from 'jsdom'
import { Card } from '@fiction/site/card'
import { Card } from '../../card'
import { Site } from '../../site'
import type { LayoutOrder } from '../layout'
import { getOrderRecursive, getSimpleOrderSchema, layoutOrderCards, setLayoutOrder } from '../layout'
Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/utils/test/page.ci.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { describe, expect, it, vi } from 'vitest'
import { vue, waitFor } from '@fiction/core'
import { createSiteTestUtils } from '../../test/siteTestUtils'
import { Card } from '@fiction/site/card'
import { Card } from '../../card'
import { activePageId, getPageById, getViewMap } from '../page'
import { Site } from '../../site'

Expand Down
2 changes: 1 addition & 1 deletion @fiction/site/utils/test/region.ci.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { describe, expect, it } from 'vitest'
import { waitFor } from '@fiction/core'
import { requestManageSite } from '../../load'
import { Card } from '@fiction/site/card'
import { Card } from '../../card'
import type { CardConfigPortable, TableCardConfig } from '../../tables'
import { Site } from '../../site'
import { createSiteTestUtils } from '../../test/siteTestUtils'
Expand Down
9 changes: 5 additions & 4 deletions @fiction/www/test/entryConfig.ci.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ describe('user config', () => {
"fictionRouterSites",
"fictionAws",
"fictionMedia",
"fictionAdmin",
"fictionAi",
"fictionSites",
"fictionTeam",
"fictionUi",
]
Expand Down Expand Up @@ -64,13 +65,13 @@ describe('user config', () => {
"ManageVectors",
"AiCompletion",
"AiImage",
"OrgMembers",
"TeamInvite",
"SeekInviteFromUser",
"ManageSite",
"ManageIndex",
"ManagePage",
"ManageCert",
"OrgMembers",
"TeamInvite",
"SeekInviteFromUser",
]
`)

Expand Down

0 comments on commit 603d798

Please sign in to comment.