Documenting the new client-customizable locale detection system #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mesr
changed the title
mesr
changed the title
mesr
force-pushed
the
main
branch
10 times, most recently
from
af20ad7
to
86a0e05
Compare
- Updated description of the locale detection procedure at the top of page `i18n/create-i18n.md`; - Added section `detectLocale(callback)` to pages `extending-components/with-i18n.md` and `extending-components/with-18n-reactive.md`; - Added sections `setLocaleDetectionRule(rule)` and `detectLocale(callback)` to page `i18n/create-i18n.md`.
mesr
changed the title
|
@ducksoupdev, please wait before committing this PR. There is an additional feature that I wish to propose and that might change the definition and signature of function |
|
My pleasure, @ducksoupdev. Thank you for welcoming my contribution. The appreciation goes in both directions! The documentation is almost ready to go. If you haven't already, would you mind taking a look at this proposal? Because that's an easy one to get done and, if you think it's a good idea, I feel that it would conclude very nicely this batch of new features by tying together the new reactive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setLocaleDetectionRule(rule)function;setLocale(locale)vssetLocaleDetectionRule(rule)when the latter is called with a string argument.