Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and test breadcrumbs mech #343

Closed
duker33 opened this issue Sep 18, 2019 · 2 comments · Fixed by #344
Closed

Refactor and test breadcrumbs mech #343

duker33 opened this issue Sep 18, 2019 · 2 comments · Fixed by #344
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable

Comments

@duker33
Copy link
Collaborator

duker33 commented Sep 18, 2019 •
edited

Inspired by fidals/shopelectro#961

This code pages.templatetags.pages_extras.breadcrumbs_with_siblings is monolithic and not tested.
Make it flexible and cover with unit tests
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable labels Sep 18, 2019
@duker33 duker33 self-assigned this Sep 18, 2019
@duker33 duker33 mentioned this issue Sep 18, 2019
Closed
duker33 added a commit that referenced this issue Sep 18, 2019
@duker33
#343 Drop redundant logic from siblings fetching. High level arch for…
bb2ad79 
… breadcrumbs
@duker33 duker33 mentioned this issue Sep 18, 2019
Merged
duker33 added a commit that referenced this issue Sep 20, 2019
@duker33
#343 Trigger CI
e65d289
duker33 added a commit that referenced this issue Sep 20, 2019
@duker33
#343 Fix siblings logic. Refactor Breadcrumbs arch (#344)
202424c 
* #343  Drop redundant logic from siblings fetching. High level arch for breadcrumbs

* #343  Trigger CI
@0pdd 0pdd mentioned this issue Sep 20, 2019
Closed
@0pdd
Copy link
Collaborator

0pdd commented Sep 20, 2019

@duker33 the puzzle #345 is still not solved; solved: #136.

@0pdd
Copy link
Collaborator

0pdd commented Sep 23, 2019

@duker33 2 puzzles #347, #348 are still not solved; solved: #136, #345.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#343 Fix siblings logic. Refactor Breadcrumbs arch fidals/refarm-site
2 participants
@duker33 @0pdd