Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_commands.py:30-32: Раздели тесты класса UpdateProducts... #181

Open
0pdd opened this issue Oct 4, 2017 · 3 comments
Open

tests_commands.py:30-32: Раздели тесты класса UpdateProducts... #181

0pdd opened this issue Oct 4, 2017 · 3 comments
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue blocked issue is blocked by another issue cleanup everything that do project stronger, flexible, reusable Import OOP cleanup the feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Oct 4, 2017

The puzzle 179-56b07b05 (from #179) in shopelectro/tests/tests_commands.py (lines 30-32) has to be resolved: "Раздели тесты класса UpdateProducts на интеграционные и модульные. 1. Используй файлы с фикстурами для модульных тестов, чтобы добиться стабильности. 2. Тестируй скачивание файлов с FTP отдельно."

The puzzle was created by Artemiy on 04-Oct-17.

Estimate: 0 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Oct 4, 2017

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Oct 4, 2017
@ArtemijRodionov
Attempt to reproduce pdd bug. (#179)
e1d413d
@duker33 duker33 added the 3 we can defer this issue. But it'll good to implement it label Oct 26, 2017
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Feb 27, 2018
@duker33 duker33 assigned a-dubrovin and unassigned chelovek-18 Mar 30, 2018
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Apr 5, 2018
@ArtemijRodionov
Copy link
Contributor

@duker33 Let's bump the issue's priority to avoid incidents of FTP

@ArtemijRodionov ArtemijRodionov added 2 performer can implement issue at his closest convenient time and removed 3 we can defer this issue. But it'll good to implement it labels Jul 24, 2018
@duker33 duker33 self-assigned this Jan 17, 2019
@duker33
Copy link
Contributor

duker33 commented Jan 18, 2019

our first task here is to test the import code separately from FTP downloading code.
It means, that we should emulate some data for inner import logic to test it.

Now it'll be hell to emulate data structures like Dict[UUID, Dict[str, Dict[str, dict]]] for tests.
Let's rewrite all import code in OOP model. It not very expensive and will be very clear for tests.

@Artemiy , lets discuss it in related task

@duker33 duker33 mentioned this issue Jan 18, 2019
Open
@duker33 duker33 added the blocked issue is blocked by another issue label Jan 18, 2019
@duker33 duker33 mentioned this issue Jan 18, 2019
Open
@duker33 duker33 added 1 burning issue Import OOP cleanup the feature and removed 2 performer can implement issue at his closest convenient time labels Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue blocked issue is blocked by another issue cleanup everything that do project stronger, flexible, reusable Import OOP cleanup the feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@duker33 @a-dubrovin @chelovek-18 @ArtemijRodionov @0pdd