Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-compose.yml:56-57: if Validate .env is full Is... #250

Closed
0pdd opened this issue Dec 26, 2017 · 3 comments
Closed

docker-compose.yml:56-57: if Validate .env is full Is... #250

0pdd opened this issue Dec 26, 2017 · 3 comments
Labels
1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it

Comments

@0pdd
Copy link
Collaborator

0pdd commented Dec 26, 2017

The puzzle 229-a984cd8e from #229 has to be resolved:

shopelectro/docker/docker-compose.yml

Lines 56 to 57 in 5308166

# @todo #229 if Validate `.env` is full
# Is full means '.env` contains all keynames from `.env.dist`

The puzzle was created by duker33 on 26-Dec-17.

Estimate: 0 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 26, 2017

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Dec 26, 2017
@duker33
#229 Document local env building (#249)
5308166
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time labels Dec 26, 2017
@duker33 duker33 added take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Feb 26, 2018
@duker33
Copy link
Contributor

duker33 commented May 11, 2018

connected with #280

@duker33 duker33 mentioned this issue May 11, 2018
Merged
@0pdd 0pdd closed this as completed May 16, 2018
@0pdd
Copy link
Collaborator Author

0pdd commented May 16, 2018

The puzzle 229-a984cd8e has disappeared from the source code, that's why I closed this issue. //cc @artemiyds2 @duker33

0pdd referenced this issue May 16, 2018
@ArtemijRodionov @duker33
#269 Refactor deploy system (#280)
64e26c0 
* Refactor docker-compose files. Refactor the structure of docker/ folder. Create bash script for environment files

- Remove redundant se- prefix from services names of docker-compose files
- Create a docker-compose.yml to build images. Move Dockerfiles to docker/images
- Create env files, refactor the docker-compose files.
- Finish testing of docker-compose.yml
- Add dist for env files
- Finish create-env.sh
- Return back prod volumes
- Update create-env
- Add DS_store to .gitignore
- Create comment for create-env
- Finish with Makefile
- Update .drone.yml
- Delete redundant spaces
- Update clean pipe of CI
- Update environment variables for ci
- Review fixes
- Review fixes 2
- Update deploy-dev receipt in Makefile and docker-build pipe in .drone.yml
- Fix tests
- * #269  Fix create-env.sh and .env UI. Add static generation to deploy-dev make recipe
@0pdd 0pdd mentioned this issue May 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable take it any teammate can take this issue and start working with it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd