Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken drone docker-push system. stb2 #321

Closed
duker33 opened this issue Jun 2, 2018 · 9 comments
Closed

Broken drone docker-push system. stb2 #321

duker33 opened this issue Jun 2, 2018 · 9 comments
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business

Comments

@duker33
Copy link
Contributor

duker33 commented Jun 2, 2018 •
edited

Drone don't watch on master branch. And don't do docker-push after merge in master

UPD: refresh drone code, by the way. No it fully freeze web UI during working
@duker33 duker33 added bug 1 hour typical issue size. It's one pdd hour 1 burning issue take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Jun 2, 2018
@duker33 duker33 mentioned this issue Jun 3, 2018
Closed
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Jun 9, 2018
@duker33 duker33 self-assigned this Jun 9, 2018
@duker33
Copy link
Contributor Author

duker33 commented Jun 9, 2018

problem discussed here:
https://discourse.drone.io/t/how-do-you-trigger-builds-when-a-pr-is-merged/1629/2

@duker33 duker33 added the blocked issue is blocked by another issue label Jun 9, 2018
@duker33
Copy link
Contributor Author

duker33 commented Jun 9, 2018 •
edited

logs contain nothing suspicious. Just renewed drone itself. Maybe bug will go away.
Let's do some merges and see

@ArtemijRodionov
Copy link
Contributor

I am going to enable push hook for drone, which exuecutes build. Seems it will resolve the issue

Here: #342

@duker33
Copy link
Contributor Author

duker33 commented Jun 9, 2018

@artemiy312 , hmm, looks strange. Commented for a little.

and it's not clear why

    when:
      event: push
      branch: master

helps to resolve issue

@ArtemijRodionov
Copy link
Contributor

ArtemijRodionov commented Jun 13, 2018 •
edited

@duker33 Currently the push hooks are disabled
default

When PR will be merged, we may to enable push hook to perform master builds.

when: ... options are needed to filter push hooks for non-master or not targeted to master branches

@ArtemijRodionov
Copy link
Contributor

ArtemijRodionov commented Jun 13, 2018 •
edited

@duker33

It works as I expected
default

@ArtemijRodionov ArtemijRodionov mentioned this issue Jun 13, 2018
Closed
@duker33 duker33 assigned ArtemijRodionov and unassigned duker33 Jun 14, 2018
@duker33
Copy link
Contributor Author

duker33 commented Jun 14, 2018

@artemiy312 ,

Currently the push hooks are disabled

it's strange, i enabled it several days ago

@duker33
Copy link
Contributor Author

duker33 commented Jun 14, 2018

it seems this task resolved. But one bug left.
It's here: #347

@duker33 duker33 closed this as completed Jun 14, 2018
@duker33 duker33 added report Put it to completed tasks temporary list for business and removed blocked issue is blocked by another issue labels Jun 14, 2018
@duker33
Copy link
Contributor Author

duker33 commented Jun 15, 2018

y, it works: https://ci.fidals.com/fidals/shopelectro/167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue bug cleanup everything that do project stronger, flexible, reusable report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @ArtemijRodionov