This repository has been archived by the owner on Feb 23, 2020. It is now read-only.
search.py:16-17: Create active() shortcut filter... #140
Comments
@artemiyds2 @duker33 please pay attention to this new issue. |
0pdd
referenced
this issue
Nov 20, 2017
* rf#85 Adapt search code to new refarm interface * rf#85 Add env type var * rf#85 Fix some debug settings * rf#85 Fix product's list filtering algo on CategoryPage * rf#85 Fix product's list filtering algo on CategoryPage * rf#85 Debug travis * rf#85 Fix broken tests * rf#85 Debug travis * rf#85 Debug travis * rf#85 Fix codestyle * rf#85 Review fix. Fix dc stb-nodejs service's default command * rf#85 Review codestyle and comments fixes * rf#85 Debug drone ci and tests * rf#85 Debug tests
duker33
added
30 mins
small issues. Usually cosmetic fixes
3
we can defer this issue. But it'll good to implement it
take it
any teammate can take this issue and start working with it
cleanup
everything that do project stronger, flexible, reusable
easy
new teammates can start with such issues to become familiar with project
labels
Feb 27, 2018
chelovek-18
removed
the
take it
any teammate can take this issue and start working with it
label
Apr 21, 2018
chelovek-18
added a commit
that referenced
this issue
Apr 21, 2018
Вынес в функцию active весь блок search_engine.Search. Если это реально, можно было бы вообще убрать ее как метод внутрь класса. Либо, если не очень, могу откатить и заменить только метод filter на active
chelovek-18
added a commit
that referenced
this issue
Apr 21, 2018
Весть блок search_engine.Search вынесен в функцию active. По идее ее можно вообще вынести в метод класса. Или, если так не очень, могу откатить и заменить на active только .filter
chelovek-18
added a commit
that referenced
this issue
Apr 21, 2018
Весь блок search_engine.Search вынесен в active(). Далее функцию можно вынести в метод класса. Или откатить если что и заменить на action только .filter
@chelovek-18 # всесто этого
Category.objects.filter(page__is_active=True)
# нам нужно вызывать это
Category.objects.get_active() |
Closed
chelovek-18
added a commit
that referenced
this issue
Apr 22, 2018
Для классов Category и Product сделал, а вот для класса Page так и не понял, надо ли вообще. Никак не смог его найти - такое ощущение что это некий базовый класс?..
chelovek-18
added a commit
that referenced
this issue
Apr 22, 2018
Сделал для классов Category и Product. Для Page не понял, надо ли вообще делать. Не смог найти его, сложилось ощущение что это некий базовый класс.
chelovek-18
added a commit
that referenced
this issue
Apr 22, 2018
Сделал для классов Product и Category. Для класса Page не понял, надо ли вообще делать - не нашел его, это некий базовый класс судя во всему?
chelovek-18
added a commit
that referenced
this issue
Apr 25, 2018
Изменение версии refarm-site в requirements.txt
ArtemijRodionov
pushed a commit
that referenced
this issue
May 5, 2018
Добавление метода get_active в search.py и версию refarm-site
ArtemijRodionov
added
the
report
Put it to completed tasks temporary list for business
label
May 6, 2018
0pdd
referenced
this issue
Oct 23, 2018
* rf#169 Remove get_active method * rf#169 Review#2 fix. Rm ActiveManagers in favour of QS.active() * rf#169 Apply linter rules after merge * rf#169 Grade refarm dep to 0.4.3 * rf#169 Reverted `active` method shortcut call. Created pdd with models inheritance issue * rf#169 Grade refarm dep to 0.4.4
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The puzzle
85-600a6da3
(from #85) instroyprombeton/views/search.py
(lines 16-17) has to be resolved: "Create active() shortcut filter instead of using .filter(page__is_active=True)"The puzzle was created by duker33 on 20-Nov-17.
Estimate: 0 minutes, role: IMP.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
The text was updated successfully, but these errors were encountered: