Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

tests_selenium_admin.py:294-295: Stabilize TableEditor... #316

Closed
0pdd opened this issue Sep 24, 2018 · 3 comments
Closed

tests_selenium_admin.py:294-295: Stabilize TableEditor... #316

0pdd opened this issue Sep 24, 2018 · 3 comments
Assignees
Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 24, 2018

The puzzle 187-1700602f from #187 has to be resolved:

# @todo #187:120m Stabilize TableEditor selenium tests
# Write them on event based model instead of plain waits.

The puzzle was created by duker33 on 24-Sep-18.

Estimate: 120 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Collaborator Author

0pdd commented Sep 24, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Sep 24, 2018
- Fix import module style in views.catalog
- Integrate views context
- Add tags to front. Add tags in test_db generation
- Add front code for tags
- Pin refarm's branch dep
- Minor self-review fixes
- Review #1 fixes. Front props iteration style and test classes naming
- Add missed migrations
- Grade refarm dep to 0.4.2
- Fix error in migrations
- Minor migration fix
- Skip some new CatalogTag tests. Add pdd task to resurrect them
- Rm redundant const. Skip problem tests in selenium admin
- Hardcode some bugged drone secrets
- Apply linter rules
@0pdd 0pdd mentioned this issue Sep 24, 2018
@duker33 duker33 added 2 hours some big and monolith issues. For example with hard decisions or discussions 1 burning issue take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Sep 24, 2018
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Jan 14, 2019
@duker33 duker33 self-assigned this Jan 14, 2019
@duker33
Copy link
Contributor

duker33 commented Jan 15, 2019

it's duplicate of #191

@duker33 duker33 closed this as completed Jan 15, 2019
@duker33 duker33 removed their assignment Jan 15, 2019
@duker33 duker33 reopened this Jan 15, 2019
@duker33 duker33 removed the duplicate label Jan 15, 2019
@duker33 duker33 self-assigned this Jan 15, 2019
@duker33
Copy link
Contributor

duker33 commented Jan 15, 2019

it seems we meant Table Editor class itself there.
So, i'll implement it as separated task

duker33 added a commit that referenced this issue Jan 17, 2019
* #191  Add event based wait to `test_product_price_filter`

* #191  Add event based waits to AdminPage filters tests

* #191  Add event based waits to AdminPage js tree tests

* #316  Move Table Editor tests waits to event based model

* #316  Fix wait event for one of the TE tests

* #316  Fix wait event for one of the TE tests #2

* #fix  Fix wait event for one of the TE tests #3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Development

No branches or pull requests

2 participants