Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

test_db.py:192-193: Adapt test_db command to Options.... #416

Closed
0pdd opened this issue Jan 30, 2019 · 2 comments
Closed

test_db.py:192-193: Adapt test_db command to Options.... #416

0pdd opened this issue Jan 30, 2019 · 2 comments
Assignees
@duker33
Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable Product options feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jan 30, 2019

The puzzle 396-cce8dc93 from #396 has to be resolved:

stroyprombeton/stroyprombeton/management/commands/test_db.py

Lines 192 to 193 in 196e6cb

# @todo #396:60m Adapt test_db command to Options.
# Then remove `null=True, blank=True` from Product.options field.

The puzzle was created by @duker33 on 30-Jan-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 30, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jan 30, 2019
@duker33
396_product_options (#401)
196e6cb 
* #396  Create Option model

* #396  Add migrations for Options model

* #396  Update locale messages. Add i18n script

* #396  Create pdd subtasks to integrate Options

* #396  Propose model renaming to "Options"

* #396  Fix code according to tests

* #396  Review fixes. Comments and subtasks

* #396  Debug tests

* #396  Debug CI #2

* #396  Downgrade python to 3.6

* #396  Skip some problem tests

* #396  Skip some problem tests

* #396  Apply linter rules
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable Product options feature labels Jan 30, 2019
@duker33 duker33 self-assigned this Jan 30, 2019
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Jan 30, 2019
@duker33
Copy link
Contributor

duker33 commented Jan 30, 2019

met problems with super(BaseCommand, self).__init__() and products options initial creating

duker33 added a commit that referenced this issue Jan 30, 2019
@duker33
#416 Adapt test_db to Options
253ed6b
@duker33 duker33 mentioned this issue Jan 30, 2019
Merged
duker33 added a commit that referenced this issue Jan 30, 2019
@duker33
#416 Adapt test_db to Options
7343e33
duker33 added a commit that referenced this issue Jan 31, 2019
@duker33
#416 Add fixtures to cvs
08dee2e
duker33 added a commit that referenced this issue Jan 31, 2019
@duker33
#416 Return old fixtures file
b111082
duker33 added a commit that referenced this issue Jan 31, 2019
@duker33
#416 Apply linter rules
b4ab296
duker33 added a commit that referenced this issue Jan 31, 2019
@duker33
416_options_to_testdb (#425)
3291dbd 
* #416  Adapt test_db to Options

* #416  Add fixtures to cvs

* #414  Rm redundant `fake_db` command

* #417  Refactor models imports

* #416  Return old fixtures file

* #416  Apply linter rules
@0pdd 0pdd mentioned this issue Jan 31, 2019
Closed
0pdd referenced this issue Feb 6, 2019
@ArtemijRodionov
#413 #428 integrate Option to price command (#429)
43318f6 
* Reverse the Options relation

* Fix test_db

* Create relevant fixtures

* Adopt price command for Option

* Self review fixes

* Review fixes

* Undo Product.price in test_db command.

* Apply linter rules
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@duker33 duker33

Labels
1 hour typical issue size. It's one pdd hour. Performer should spend about one astronomical hour for this i 1 burning issue cleanup everything that do project stronger, flexible, reusable Product options feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd