Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

catalog.py:22-24: Move fetch_products to new context. Rm... #443

Closed
0pdd opened this issue Feb 19, 2019 · 6 comments
Closed

catalog.py:22-24: Move fetch_products to new context. Rm... #443

0pdd opened this issue Feb 19, 2019 · 6 comments
Assignees
@duker33
Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Feb 19, 2019

The puzzle 431-8ca0a87d from #431 has to be resolved:

stroyprombeton/stroyprombeton/views/catalog.py

Lines 22 to 24 in 23c3167

# @todo #431:120m Move fetch_products to new context.
# Rm `settings.PRODUCTS_ON_PAGE_*` after moving.
# And rm old context code.

The puzzle was created by duker33 on 19-Feb-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Feb 19, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Feb 19, 2019
@duker33
#431 Move catalog view to the new context (#440) (#442)
23c3167 
* #431  Tag catalog tests

* #fix  Fix index page url reverse

* #431  Boilerplate for the new context integration

* #431  Create request data class

* #431  Draft for new context using

* #431  Fix tests. Create some subtasks

* #431  Minor fix

* #431  Hit CI

* #431  Grade refarm dep to the newest version

* #431  Fix total products count rendering
@0pdd 0pdd mentioned this issue Feb 19, 2019
Closed
@duker33 duker33 self-assigned this Feb 19, 2019
@duker33 duker33 added 2 hours some big and monolith issues. For example with hard decisions or discussions 1 burning issue cleanup everything that do project stronger, flexible, reusable labels Feb 19, 2019
duker33 added a commit that referenced this issue Feb 19, 2019
@duker33
#443 Fix subtask
cb25c8c
duker33 added a commit that referenced this issue Feb 19, 2019
@duker33
#443 Rename LoadMore to FetchProducts
be1b9d8 
#443  Minor fixes

#443  Create subtask for arch improvements

#443  Implement fetch products with new context

#xxx  Create LoadMore context class
duker33 added a commit that referenced this issue Feb 19, 2019
@duker33
#443 Rm redundant settings param
7c214ec
@duker33 duker33 mentioned this issue Feb 19, 2019
Merged
duker33 added a commit that referenced this issue Feb 19, 2019
@duker33
#443 Rm ready pdd task
e9dbb2c
@duker33 duker33 mentioned this issue Feb 19, 2019
Merged
duker33 added a commit that referenced this issue Feb 20, 2019
@duker33
#443 Drop redundant context class
c4bc628
duker33 added a commit that referenced this issue Feb 20, 2019
@duker33
#443 Rm old context classes
af313fd
duker33 added a commit that referenced this issue Feb 20, 2019
@duker33
#443 Grade refarm dep to 0.4.34
fbb4196
duker33 added a commit that referenced this issue Feb 20, 2019
@duker33
#443 Review#1. Clarify pdd subtask body
5a4b83f
duker33 added a commit that referenced this issue Feb 21, 2019
@duker33
#443 Create context.FetchProducts class (#448)
2dd8517 
* #443  Rename LoadMore to FetchProducts

#443  Minor fixes

#443  Create subtask for arch improvements

#443  Implement fetch products with new context

#xxx  Create LoadMore context class

* #443  Rm redundant settings param

* #443  Rm ready pdd task

* #fix  Rm partner

* #443  Drop redundant context class

* #443  Rm old context classes

* #443  Grade refarm dep to 0.4.34

* #443  Review#1. Clarify pdd subtask body
This was referenced Feb 21, 2019
Closed
Closed
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Feb 21, 2019

@0pdd 3 puzzles #449, #450, #451 are still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 17, 2019

@0pdd 3 puzzles #449, #450, #511 are still not solved; solved: #451.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 18, 2019

@0pdd 3 puzzles #511, #514, #515 are still not solved; solved: #449, #450, #451.

@0pdd
Copy link
Collaborator Author

0pdd commented Mar 20, 2019

@0pdd 5 puzzles #511, #518, #519, #520, #521 are still not solved; solved: #449, #450, #451, #514, #515.

@0pdd
Copy link
Collaborator Author

0pdd commented Apr 12, 2019

@0pdd 4 puzzles #511, #518, #519, #598 are still not solved; solved: #449, #450, #451, #514, #515, #520, #521.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@duker33 duker33

Labels
1 burning issue 2 hours some big and monolith issues. For example with hard decisions or discussions cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd