Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

models.py:207: Drop Product.is_popular field. #496

Closed
0pdd opened this issue Mar 11, 2019 · 1 comment
Closed

models.py:207: Drop Product.is_popular field. #496

0pdd opened this issue Mar 11, 2019 · 1 comment
Assignees
@duker33
Labels
1 burning issue 30 mins small issues. Usually cosmetic fixes easy new teammates can start with such issues to become familiar with project

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 11, 2019

The puzzle 483-f2f590b6 from #483 has to be resolved:

stroyprombeton/stroyprombeton/models.py

Line 207 in bc0f7a6

# @todo #483:30m Drop `Product.is_popular` field.

The puzzle was created by duker33 on 11-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 11, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Mar 11, 2019
@duker33
#483 #455 Move data from product fields to options and tags (#487)
bc0f7a6 
* #483  Draft for options and tags creation

* #483  Create options and tags

* #455  Rm data fields from Product and Option models

* #483  Review#1 fix. Move custom data migrations to RunPython

* #483  Adapt search to new DB structure

* #483  Review#1. Move product grouping to func, bind tags to options

* #483  Adapt fixtures to the new DB scheme

* #455  Fix tests

* #455  Skip some tests. Create pdd issues for them

* #483  Group products by name+category_id in migrations

* #455  Skip problem test to prevent fatal traceback in output

* #483  Make some operations bulk and atomic

* #483  Add missed pdd issues

* #483  Return back the state of temporary files

* #483  Review#3 fix

* #483  Grade refarm dep to 0.5.0

* #483  Move slug creating logic to migrations

* #483  Tests minor fixes

* #483  Skip several fallen tests
@0pdd 0pdd mentioned this issue Mar 11, 2019
Closed
@duker33 duker33 added 30 mins small issues. Usually cosmetic fixes 1 burning issue easy new teammates can start with such issues to become familiar with project labels Mar 12, 2019
@duker33 duker33 self-assigned this Mar 12, 2019
duker33 added a commit that referenced this issue Mar 23, 2019
@duker33
#485 #495 #496 Cleanup product and option relations
cc6ec55
duker33 added a commit that referenced this issue Mar 23, 2019
@duker33
#485 #495 #496 Adapt fixtures to the new database structure
0a4f670
duker33 added a commit that referenced this issue Mar 23, 2019
@duker33
#485 #495 #496 Adapt tests to the new DB structure
a530ef4
@duker33 duker33 mentioned this issue Mar 23, 2019
Merged
duker33 added a commit that referenced this issue Mar 23, 2019
@duker33
#485 #495 #496 Adapt test to the new DB structure
2315d99
duker33 added a commit that referenced this issue Mar 23, 2019
@duker33
#485 #495 #496 Skip the test with unstable structure
e43d6e9
duker33 added a commit that referenced this issue Mar 24, 2019
@duker33
#set of product/option relation fixes (#527)
ba3f4de 
* #485 #495 #496  Cleanup product and option relations

* #485 #495 #496  Adapt fixtures to the new database structure

* #485 #495 #496  Adapt tests to the new DB structure

* #485 #495 #496  Adapt test to the new DB structure

* #485 #495 #496  Skip the test with unstable structure

* #495  Create Position class to document catalog terms

* #495  Apply linter rules
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@duker33 duker33

Labels
1 burning issue 30 mins small issues. Usually cosmetic fixes easy new teammates can start with such issues to become familiar with project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd