Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

catalog.py:227: Return 404 if options list is empty not... #619

Closed
0pdd opened this issue Apr 17, 2019 · 2 comments · Fixed by #628
Closed

catalog.py:227: Return 404 if options list is empty not... #619

0pdd opened this issue Apr 17, 2019 · 2 comments · Fixed by #628
Assignees
@duker33
Labels
2 performer can implement issue at his closest convenient time 30 mins small issues. Usually cosmetic fixes Series feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Apr 17, 2019

The puzzle 610-5746c113 from #610 has to be resolved:

stroyprombeton/stroyprombeton/views/catalog.py

Line 227 in eea7732

# @todo #610:30m Return 404 if options list is empty not found.

The puzzle was created by duker33 on 17-Apr-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 17, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Apr 17, 2019
@duker33
#610 Series category (#614)
eea7732 
* #610  Create series-category page

* #610  Create label about filtered options on series page

* #610  Filter category descendants in depth

* #610  Implement linter rule
This was referenced Apr 17, 2019
Closed
Closed
@duker33 duker33 added 2 performer can implement issue at his closest convenient time 30 mins small issues. Usually cosmetic fixes Series feature take it any teammate can take this issue and start working with it labels Apr 17, 2019
@duker33 duker33 self-assigned this Apr 19, 2019
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Apr 19, 2019
@duker33 duker33 mentioned this issue Apr 19, 2019
Closed
9 tasks
duker33 added a commit that referenced this issue Apr 19, 2019
@duker33
#619 Return 404 for category with no options
1737d6f
@duker33 duker33 mentioned this issue Apr 19, 2019
Merged
duker33 added a commit that referenced this issue Apr 21, 2019
@duker33
#622 #619 Series fixes from prod (#628)
0b17e23 
* #622  Fix not shown item names at the search results

* #619  Return 404 for category with no options

* #622  Return 404 for categories with no active options

* #622  Rm redundant CategoryTile tests

* #622  Show mark column at the options list on product page

* #622  Fix test

* #622  Drop unused import

* #622  Fix test
@0pdd 0pdd mentioned this issue Apr 21, 2019
Open
@0pdd
Copy link
Collaborator Author

0pdd commented Apr 21, 2019

@0pdd the puzzle #631 is still not solved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@duker33 duker33

Labels
2 performer can implement issue at his closest convenient time 30 mins small issues. Usually cosmetic fixes Series feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#622 #619 Series fixes from prod fidals/stroyprombeton
2 participants
@duker33 @0pdd