Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

Bad dimension units at tags content #746

Closed
duker33 opened this issue Jul 10, 2019 · 6 comments
Closed

Bad dimension units at tags content #746

duker33 opened this issue Jul 10, 2019 · 6 comments
Assignees
Labels
1 burning issue 30 mins small issues. Usually cosmetic fixes bug Data Feature about migrating data on prod from PO from product owner. It's hellxi

Comments

@duker33
Copy link
Contributor

duker33 commented Jul 10, 2019

It should be "Длина 8000 мм", but not "Длина 8000 м".
Explore if every value "длина/ширина/высота" dimension should have "мм" instead of "м" units.
If should change it with script. If not, the task will wait for stalbeton catalog taking (#738 with all subtasks)

image

@duker33 duker33 added bug 30 mins small issues. Usually cosmetic fixes 1 burning issue from PO from product owner. It's hellxi Data Feature about migrating data on prod labels Jul 10, 2019
@duker33 duker33 self-assigned this Jul 10, 2019
@duker33
Copy link
Contributor Author

duker33 commented Jul 10, 2019

take additional 30 mins for units change, if you'll change them

@ArtemijRodionov
Copy link
Contributor

I need to explore Длина, Высота, Ширина, Внешний диаметр, Внутренний диаметр tag groups

@ArtemijRodionov
Copy link
Contributor

ArtemijRodionov commented Jul 17, 2019

We have tags with м from 0 to 26000.

I believe we should move every tag with м >20+2 for length, >4 for height, >2.55 for width and inner/outer diameter to мм units, because these numbers are dimensions restriction of cargo for transportation. 23.5 paragraph
Every GBI is transported by truck, @duker33 isn't it?

@duker33
Copy link
Contributor Author

duker33 commented Jul 17, 2019

@artemiy312 , y, every GBI presented with catalog should obey standart dimensions limits. You've done a great job finding 23.5 paragraph, thx!
Let's take your's formula to fix dimensions

@ArtemijRodionov
Copy link
Contributor

@duker33 I'll create separate issue to fix it

@duker33
Copy link
Contributor Author

duker33 commented Jul 18, 2019

@artemiy312 , if you'll implement the new task for your own, you can just increase time here instead of creating it. Your script will not append our codebase, so it's not necessary to create separated task

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 burning issue 30 mins small issues. Usually cosmetic fixes bug Data Feature about migrating data on prod from PO from product owner. It's hellxi
Projects
None yet
Development

No branches or pull requests

2 participants