Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

se#475 Add ga(...) to uglify's reserved #285

Merged
merged 1 commit into from Aug 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions gulpfile.babel.js
Expand Up @@ -234,7 +234,7 @@ function vendorJS(source, destination, fileName) {
.pipe($.changed(path.build.js, { extension: '.js' }))
.pipe($.concat(`${fileName}.js`))
.pipe($.rename({ suffix: '.min' }))
.pipe($.uglify())
.pipe($.uglify({ mangle: { reserved: ['ga'] } }))
.pipe(gulp.dest(destination));
}

Expand All @@ -249,7 +249,12 @@ function appJS(source, destination, fileName) {
compact: false,
}))
.pipe($.rename({ suffix: '.min' }))
.pipe($.if(env.production, $.uglify()))
.pipe($.if(
env.production,
$.uglify({
mangle: { reserved: ['ga'] },
})
))
.pipe($.if(env.development, $.sourcemaps.write('.')))
.pipe(gulp.dest(destination))
.pipe($.livereload());
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -36,7 +36,7 @@
"gulp-sass": "^3.1.0",
"gulp-sass-glob": "^1.0.6",
"gulp-sourcemaps": "^2.4.0",
"gulp-uglify": "^2.1.0",
"gulp-uglify": "^3.0.1",
"gulp.spritesmith": "^6.3.0",
"gulplog": "^1.0.0",
"postcss-csso": "^2.0.0",
Expand Down
10 changes: 2 additions & 8 deletions templates/layout/google_tag_manager.html
Expand Up @@ -21,20 +21,14 @@
{% else %}
{% if is_head_tag %}
<script>
var gaContext = (function() {
var ga = (function() {
var results = [];

var fn = function(action, params) {
return function(action, params) {
results.push([action, params]);
console.log('GA:', JSON.stringify([action, params]));
};

return {
fn: fn,
results: results,
}
}());
var ga = gaContext.fn;

window.dataLayer = (function() {
var results = [];
Expand Down