Skip to content
This repository has been archived by the owner on Feb 23, 2020. It is now read-only.

#348 divide tests #349

Merged
merged 1 commit into from
Nov 22, 2018
Merged

#348 divide tests #349

merged 1 commit into from
Nov 22, 2018

Conversation

ArtemijRodionov
Copy link
Contributor

Closes #348

@ArtemijRodionov ArtemijRodionov self-assigned this Nov 18, 2018
@ArtemijRodionov ArtemijRodionov force-pushed the 348-divide-tests branch 4 times, most recently from cbf21ed to af55e8b Compare November 18, 2018 15:11
@duker33
Copy link
Contributor

duker33 commented Nov 19, 2018

@artemiy312 , idea and code are good. But we should detect tests with no tags somehow.
It'll be good to make all tests fail, if we have some.

But right now we can just run ... python manage.py --exclude-tag fast slow before fast tests

Copy link
Contributor

@duker33 duker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed mech for untagged tests

@ArtemijRodionov
Copy link
Contributor Author

@duker33 Let's --exclude-tag fast slow as work around, but it would be nice to define our test runner, that will check, that each test is tagged. I create todo for it.

@duker33
Copy link
Contributor

duker33 commented Nov 19, 2018

@artemiy312 , y, that's pretty what i mean

Add a fast-test pipeline

Add a check to ensure that each test is tagged. Create a todo to do it properly.

Keep db in fast-test
@ArtemijRodionov ArtemijRodionov merged commit 4add603 into master Nov 22, 2018
@ArtemijRodionov ArtemijRodionov deleted the 348-divide-tests branch November 22, 2018 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants