-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add multi-arch images amd64 and arm64 #382
feat: add multi-arch images amd64 and arm64 #382
Conversation
…ERIMENTAL flag, add Set up QEMU step, and which to GH_PAT for titlecheck
Turns out we cannot merge this until these dependencies have been updated:
Also, there is a
https://github.com/fidelity/kconnect/blob/main/docs/book/src/release.md EDIT: Looks like |
…ecific binary, update goreleaser to build arm version specifc, and remove arm32 requirement from deps
…support arm64 going forward
Verified kconnect is running as non-root user
Verified that the new binaries exist
Verified kconnect can connect to a cluster
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Gearheads
What this PR does / why we need it:
This PR add steps for creating images per architecture per Dockerfile, and then grouping those images with
docker manifest
to create multi-architecture Docker images.Also, changes theGITHUB_TOKEN
fortitlechecktitlecheck
in an attempt to resolve the issueError: Resource not accessible by integration
.For reference: aslafy-z/conventional-pr-title-action#119
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #374, fixes #387