Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Classes -- Bug Fix #141

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Nested Classes -- Bug Fix #141

merged 3 commits into from
Oct 28, 2021

Conversation

ncilfone
Copy link
Contributor

fixes issues wrt more than 2 levels of class nesting references. code was assuming to fall back on defaults instead of recursing the config space to set the correct parameters.

Handles (#139)

  • extra unit tests
  • linted

…ssuming to fall back on defaults instead of recursing the config space to set the correct parameters.
@ncilfone ncilfone self-assigned this Oct 28, 2021
@coveralls
Copy link

coveralls commented Oct 28, 2021

Pull Request Test Coverage Report for Build 1396170516

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 93.235%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spock/backend/builder.py 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
spock/backend/builder.py 1 85.46%
spock/backend/typed.py 1 96.4%
Totals Coverage Status
Change from base Build 1387165605: 0.1%
Covered Lines: 1392
Relevant Lines: 1493

💛 - Coveralls

@ncilfone ncilfone merged commit e9ca40b into master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double nested class type with Enum fails to identify the str to Enum map
2 participants