Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more stubs to cover all import paths #207

Merged
merged 2 commits into from
Jan 21, 2022
Merged

more stubs to cover all import paths #207

merged 2 commits into from
Jan 21, 2022

Conversation

ncilfone
Copy link
Contributor

pylance/pyright sometimes won't be able to find the stubs for a buried import path. Seeing as we expose the underlying decorator via some renames and imports within __init__.py this adds stubs to all the different version to make sure the @spock decorator can be type hinted correctly in VSCode and other tools that use pyright/pylance.

@ncilfone ncilfone added the bug Something isn't working label Jan 21, 2022
@coveralls
Copy link

coveralls commented Jan 21, 2022

Pull Request Test Coverage Report for Build 1729236093

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.166%

Totals Coverage Status
Change from base Build 1725758513: 0.2%
Covered Lines: 1693
Relevant Lines: 1779

💛 - Coveralls

@ncilfone ncilfone merged commit cbbcf1a into master Jan 21, 2022
@ncilfone ncilfone deleted the more_stubs branch January 21, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants