Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy eval bug #218

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Lazy eval bug #218

merged 1 commit into from
Feb 1, 2022

Conversation

ncilfone
Copy link
Contributor

@ncilfone ncilfone commented Feb 1, 2022

What does this PR do?

resolves bug in lazy search where duplicated classes would occur

Checklist

  • Did you adhere to PEP-8 standards?
  • Did you run black and isort prior to submitting your PR?
  • Does your PR pass all existing unit tests?
  • Did you add associated unit tests for any additional functionality?
  • Did you provide documentation (Google Docstring format) whenever possible, even for simple functions or classes?

@ncilfone ncilfone added the bug Something isn't working label Feb 1, 2022
@ncilfone ncilfone self-assigned this Feb 1, 2022
@coveralls
Copy link

coveralls commented Feb 1, 2022

Pull Request Test Coverage Report for Build 1780526184

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 96.158%

Totals Coverage Status
Change from base Build 1773319017: 0.2%
Covered Lines: 1777
Relevant Lines: 1848

💛 - Coveralls

@ncilfone ncilfone merged commit 3315430 into master Feb 1, 2022
@ncilfone ncilfone deleted the lazy_bug_fix branch February 1, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants