Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callable Types & Post Init Hooks #226

Merged
merged 9 commits into from Mar 11, 2022
Merged

Callable Types & Post Init Hooks #226

merged 9 commits into from Mar 11, 2022

Conversation

ncilfone
Copy link
Contributor

What does this PR do?

  • Adds support for typing.Callable types
  • Adds post init hooks to run validation on the instantiated classes
  • Adds some common validations to utils
  • Additional unit tests.
  • Updates all unit tests to include python 3.10

Checklist

  • Did you adhere to PEP-8 standards?
  • Did you run black and isort prior to submitting your PR?
  • Does your PR pass all existing unit tests?
  • Did you add associated unit tests for any additional functionality?
  • Did you provide documentation (Google Docstring format) whenever possible, even for simple functions or classes?

…alidation on the instantiated classes. Adds some common validations to utils. Adds unit tests. Updates all unit tests to run on python 3.10
@ncilfone ncilfone added the enhancement New feature or request label Mar 11, 2022
@ncilfone ncilfone self-assigned this Mar 11, 2022
@coveralls
Copy link

coveralls commented Mar 11, 2022

Pull Request Test Coverage Report for Build 1971099697

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 82 of 89 (92.13%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 96.031%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spock/backend/field_handlers.py 20 22 90.91%
spock/utils.py 32 37 86.49%
Totals Coverage Status
Change from base Build 1934893813: 0.04%
Covered Lines: 1839
Relevant Lines: 1915

💛 - Coveralls

@ncilfone ncilfone merged commit 0d4b82a into master Mar 11, 2022
@ncilfone ncilfone deleted the callable branch March 11, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants