Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] S3 support for spock config files #56

Merged
merged 9 commits into from
May 10, 2021
Merged

[WIP] S3 support for spock config files #56

merged 9 commits into from
May 10, 2021

Conversation

ncilfone
Copy link
Contributor

@ncilfone ncilfone commented May 4, 2021

S3 support for spock config files.

WIP: Currently loading is implemented and passes local testing (unit tests to come via moto). Still need to implement saving (aka uploading to S3).

Signed-off-by: Nicholas Cilfone nicholas.cilfone@fmr.com

…ted and passes local testing (unit tests to come via moto). Still need to implement saving (aka uploading to S3).

Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
@ncilfone ncilfone linked an issue May 4, 2021 that may be closed by this pull request
Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
@coveralls
Copy link

coveralls commented May 5, 2021

Pull Request Test Coverage Report for Build 813535057

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 74 of 134 (55.22%) changed or added relevant lines in 10 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-5.7%) to 90.192%

Changes Missing Coverage Covered Lines Changed/Added Lines %
spock/backend/attr/payload.py 2 3 66.67%
spock/backend/attr/saver.py 2 3 66.67%
spock/handlers.py 28 29 96.55%
spock/addons/s3/init.py 0 2 0.0%
spock/addons/init.py 0 3 0.0%
spock/backend/base.py 30 33 90.91%
spock/addons/s3/utils.py 0 49 0.0%
Files with Coverage Reduction New Missed Lines %
spock/handlers.py 6 90.0%
Totals Coverage Status
Change from base Build 726869785: -5.7%
Covered Lines: 846
Relevant Lines: 938

💛 - Coveralls

@ncilfone ncilfone changed the title S3 support for spock config files [WIP] S3 support for spock config files May 5, 2021
@ncilfone ncilfone marked this pull request as draft May 5, 2021 13:23
@ncilfone ncilfone self-assigned this May 5, 2021
Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
… purposes.

Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
@ncilfone ncilfone marked this pull request as ready for review May 10, 2021 13:23
@ncilfone ncilfone added the enhancement New feature or request label May 10, 2021
Signed-off-by: Nicholas Cilfone <nicholas.cilfone@fmr.com>
@ncilfone ncilfone merged commit da396a7 into master May 10, 2021
@ncilfone ncilfone deleted the s3 branch May 10, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS S3 Integration
2 participants