Doc2Vec update on negative sampling #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates -
. Fixed the test cases where negative sampling was set to 0 for Doc2Vec. Updated the value with 5(default value)
Reason for the error -
We must set either 'hs' (hierarchical softmax) or 'negative' to be positive for proper training. When both 'hs=0' and 'negative=0', there will be no training.
The cause for the above error being Doc2Vec do not update word embeddings if negative keyword is set to 0. So, in order to mitigate this, the contributors added a sanity check to the hs and negative arguments which checks if both hs and negative are set to 0 and throws the above error.
Here is the approved PR in the Gensim Library for the above check- piskvorky/gensim#3443