Fix/failed ci #15
Fix/failed ci #15
Conversation
Update requirements to fix `scipy.linalg` and `triu` import issue Signed-off-by: Karthik Uppuluri <karthik.uppuluri@fmr.com>
Drop 3.7 and add 3.11 support for python versions Signed-off-by: Karthik Uppuluri <karthik.uppuluri@fmr.com>
| @@ -1,6 +1,7 @@ | |||
| numpy | |||
| flair>=0.9 | |||
| gensim>=4.0 | |||
| scipy<1.13 | |||
There was a problem hiding this comment.
hmm this is interesting.. does that mean, we can never update our scipty / go beyond 1.12?
There was a problem hiding this comment.
If lingalg operations are decomissioned, what's their suggested alternative OR the right way of doing that now?
It seems to me that, there is an alternative here to actually not fixtate to sth old but to make the jump by changing how we use linalg, no?
There was a problem hiding this comment.
This issue is resulting from a dowstream library we use gensim. They are still in the process of releasing a fix for this, until then our best bet is to fix the scipy version. piskvorky/gensim#3525
My PR is still WIP, for some reason when I create a PR, even if I don't assign a reviewer, I guess it sends an email to you. I will get this done most probably by tomorrow and it will be casual approval for now. Thanks for the review.
| @@ -15,7 +15,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ['3.7', '3.8', '3.9', '3.10'] | |||
| python-version: ['3.8', '3.9', '3.10', '3.11'] | |||
There was a problem hiding this comment.
https://github.com/fidelity/textwiser?tab=readme-ov-file#installation
We stil say 3.6+, which seems inaccurate. Given that these versions of Python are decommisioned now, shall we jump to Python 3.8+? This needs changing the README and possible the Docs?
There was a problem hiding this comment.
@kuppulur shall we update the docs as well? see the link above
There was a problem hiding this comment.
I updated the docs as well. Thanks for the comment.
| @@ -1,6 +1,7 @@ | |||
| numpy | |||
| flair>=0.9 | |||
| gensim>=4.0 | |||
| scipy<1.13 | |||
There was a problem hiding this comment.
If lingalg operations are decomissioned, what's their suggested alternative OR the right way of doing that now?
It seems to me that, there is an alternative here to actually not fixtate to sth old but to make the jump by changing how we use linalg, no?
Signed-off-by: Karthik Uppuluri <karthik.uppuluri@fmr.com>
Fixing Scipy to be less than 1.13 until Gensim releases a fix. Signed-off-by: Karthik Uppuluri <karthik.uppuluri@fmr.com>
Temporarily commented three tests which fail due to scipy version. Once the Gensim fix is released, we shall revert back. Signed-off-by: Karthik Uppuluri <karthik.uppuluri@fmr.com>
Dropping support for 3.6 and 3.7. Signed-off-by: Karthik Uppuluri <karthik.uppuluri@fmr.com>
Dropping support for 3.6 and 3.7 Python versions. Signed-off-by: Karthik Uppuluri <karthik.uppuluri@fmr.com>
Signed-off-by: Karthik Uppuluri <karthik.uppuluri@fmr.com>
| @@ -15,7 +15,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ['3.7', '3.8', '3.9', '3.10'] | |||
| python-version: ['3.8', '3.9', '3.10', '3.11'] | |||
There was a problem hiding this comment.
@kuppulur shall we update the docs as well? see the link above
| @@ -1,6 +1,7 @@ | |||
| numpy | |||
| flair>=0.9 | |||
| gensim>=4.0 | |||
| scipy<1.13 | |||
This PR is to fix the following CI issue and drop support for Python 3.7.
Issue:
The
scipy.linalgfunctions tri, triu & tril are deprecated and will be removed in SciPy 1.13.So, updating the requirements to have a version less than 1.13.