Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor log calls to include request id from context #229

Merged
merged 12 commits into from
May 10, 2023

Conversation

padraigmc
Copy link
Collaborator

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

michael12312
michael12312 previously approved these changes May 5, 2023
kishoregv
kishoregv previously approved these changes May 10, 2023
Copy link
Contributor

@kishoregv kishoregv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Pádraig McCarthy <padraig.mccarthy@fmr.com>
@padraigmc padraigmc merged commit 9c2f003 into main May 10, 2023
6 checks passed
@padraigmc padraigmc deleted the refactor-log-with-context branch May 10, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants