Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS: Fix fetching of latest version number #508

Merged
merged 1 commit into from Oct 16, 2015

Conversation

franzliedke
Copy link
Contributor

Apparently, they changed something again. Download only works like that for me (when using "latest").

@fideloper
Copy link
Owner

Is there a better way to get the latest version? There's gotta be something less janky!

fideloper added a commit that referenced this pull request Oct 16, 2015
NodeJS: Fix fetching of latest version number
@fideloper fideloper merged commit 7af608b into fideloper:master Oct 16, 2015
@franzliedke
Copy link
Contributor Author

Hmm, maybe the GitHub tags API? I'll take a look tonight.
Am 16.10.2015 16:18 schrieb "Chris Fidao" notifications@github.com:

Merged #508 #508.


Reply to this email directly or view it on GitHub
#508 (comment).

@franzliedke
Copy link
Contributor Author

Hmm, we can use this API endpoint, which lists the latest releases. Apparently it's sorted by release date; not sure whether that can cause problems if they ever release versions for older branches...

What do you think, @fideloper?

@franzliedke
Copy link
Contributor Author

Or we can use this directory listing - that should work better.

@fideloper
Copy link
Owner

Good find!

Looks like we can get some json here: https://nodejs.org/dist/index.json
or CSV here: https://nodejs.org/dist/index.tab

And take the most recent/first value to find that (altho not sure how bad
that is to parse in bash).

On Fri, Oct 16, 2015 at 1:12 PM Franz Liedke notifications@github.com
wrote:

Or we can use this directory listing https://nodejs.org/dist/latest/ -
that should work better.


Reply to this email directly or view it on GitHub
#508 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants