New methods and solution for issue #50 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visibility of type t_column changed from protected to public. Defined new public type t_columns as table of t_column. Created new public method get_columns which returns the protected attribut columns.
Changed visibility of method set_output_table from private to public. This method needs to be called to set the output table before calling the display method. Created new method create_by_type.
added Report for demo purpose of new method create_by_type
The parameter p_full_name for calling method get_single_ref needs to be determined dynamically to work with the new method create_by_type.
The parameter subclass is no longer needed.
Inserted call of method check_if_called_from_subclass.
Changed instance generation from private to public due to syntax warnings when inheriting from zcl_falv.
In report ZDEMO_FALV15 the first FALV won't show after displaying second FALV.
Changed constructor visibility from private to public due to change of visibility of instance generation.
|
Thanks @reuteraov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.