Singletonable mixin #3
Conversation
| varargs = arguments._.tail(); | ||
|
|
||
| // Storage for the the singleton object, once it is created | ||
| var singleton; |
There was a problem hiding this comment.
Ideally I think this would be Constructor._singleton or something like that so that people could mock/override it
There was a problem hiding this comment.
Hmmm... I guess that won't really work because of the name you're using, but you could provide a setter method
There was a problem hiding this comment.
In a previous iteration, I had set configurable: true, thinking that would make it so subclasses could override it. But then I realized that that's not necessary for the subclass case, and took it off. Mocking is a good point though, so I think you're right.
I have a trick for this kind of situation where you define a property as a configurable property, but then set it when it's accessed, so it acts exactly like normal property. That'll be good because then we can use autoMock too.
| delete object[name]; | ||
| object[name] = value; | ||
| return value; | ||
| }, |
There was a problem hiding this comment.
Oh, I just realized this also needs a setter, or you won't be able to set it if it's never been accessed.
No description provided.