Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send user agent string #49

Closed
probonopd opened this issue Jul 23, 2017 · 7 comments
Closed

Send user agent string #49

probonopd opened this issue Jul 23, 2017 · 7 comments
Labels
enhancement
Projects
OctoPrintPlugin for Cura 2.7
Milestone
2.7

Comments

@probonopd
Copy link

probonopd commented Jul 23, 2017 •
edited
Loading

Please send a more informative user agent string than the current User-Agent: Mozilla/5.0 when calling the APIs.

POST /api/files/local HTTP/1.1
(...)
User-Agent: Mozilla/5.0
(...)
@fieldOfView
Copy link
Owner

Can you describe why you want/need this?

@probonopd
Copy link
Author

I am implementing a compatible server speaking the OctoPrint protocol, and to be able to determine which kind of client is resulting in which bugs that would be very useful for me.

@fieldOfView
Copy link
Owner

Any suggestion what the User Agent should be/include?

@probonopd
Copy link
Author

User-Agent: OctoPrintPlugin/<VERSION> maybe?

@fieldOfView fieldOfView self-assigned this Jul 23, 2017
@fieldOfView fieldOfView added this to the 2.7 milestone Jul 23, 2017
@nallath
Copy link
Contributor

nallath commented Jul 24, 2017

Cura uses Cura-, so OctoPrintPlugin- would be my preference, but only slightly so.

@fieldOfView
Copy link
Owner

Looking at most common user agents, Cura/2.7 would be more in line than Cura - 2.7.
I propose Cura/2.7 OctoPrintPlugin/2.7 for this plugin.

@fieldOfView fieldOfView moved this from IN PROGRESS to DONE in OctoPrintPlugin for Cura 2.7 Jul 24, 2017
@fieldOfView
Copy link
Owner

Implemented in the master branch, which will roll into the 2.7 branch shortly.

@fieldOfView fieldOfView removed their assignment Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
No open projects
OctoPrintPlugin for Cura 2.7
DONE
Milestone
2.7
Development

No branches or pull requests
3 participants
@fieldOfView @probonopd @nallath