Change "Done" to "Send Done" for better consistency and functionality…

… description
fieldrndservices · Mar 28, 2020 · 3d21057 · 3d21057
1 parent bab705a
commit 3d21057
Show file tree

Hide file tree

Showing 10 changed files with 161 additions and 59 deletions.
diff --git a/LIBSSH2.lvproj b/LIBSSH2.lvproj
diff --git a/configs/LIBSSH2.vipb b/configs/LIBSSH2.vipb
@@ -1,7 +1,7 @@
-<VI_Package_Builder_Settings Version="2018" Created_Date="2018-07-05 09:51:50" Modified_Date="2020-03-26 13:01:49" Creator="cfield" Comments="" ID="81bb203ab82699008a402aa4a60e43be">
+<VI_Package_Builder_Settings Version="2018" Created_Date="2018-07-05 09:51:50" Modified_Date="2020-03-28 12:42:57" Creator="cfield" Comments="" ID="0f5abacf9ddef26aba140014819798e2">
   <Library_General_Settings>
     <Package_File_Name>Field_RnD_Services_LIBSSH2</Package_File_Name>
-    <Library_Version>1.0.0.10</Library_Version>
+    <Library_Version>1.0.0.12</Library_Version>
     <Auto_Increment_Version>false</Auto_Increment_Version>
     <Library_Source_Folder>..\builds</Library_Source_Folder>
     <Library_Output_Folder>..\packages</Library_Output_Folder>
@@ -41,12 +41,16 @@
 
 ### Changed
 
+- "Channel.lvclass:Wait on Closed.vi" to "Channel.lvclass:Wait on Done.vi"
+- "Channel.lvclass:Closed.vi" to "Channel.lvclass:Done.vi"
+- The VI icon for the "Channel.lvclass:Done.vi"
+- The VI icon for the "Channel.lvclass:Wait on Done.vi"
 - Converting permission to and from bit masks to use Text Ring values instead of constants
 - Strict typedef enums to Text Rings with libssh2 library macro definition values
 
 ### Fixed
 
-- Session palette using Agent VIs</Release_Notes>
+- Session palette using SSH-Agent VIs</Release_Notes>
     </Description>
     <Destinations>
       <Toolkit_VIs>
@@ -389,7 +393,7 @@
         <Path>..\builds\Toolkit\SSH\Shutdown.vi</Path>
         <VI_Title>Shutdown</VI_Title>
       </Items_Data>
-      <GUID>DFA473ADC2F5A9AD0FBE2F2D6484CA16</GUID>
+      <GUID>318734E623D4E96DCC72B5FC78425190</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>0</Parent_Palette_Index>
@@ -522,7 +526,7 @@
         <Path>..\builds\Toolkit\Agent\Next Identity.vi</Path>
         <VI_Title>Next Identity</VI_Title>
       </Items_Data>
-      <GUID>A1879175669BFB078F06EF8F0482506E</GUID>
+      <GUID>2190BDBA2092D2946CB996141361E883</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>0</Parent_Palette_Index>
@@ -739,34 +743,6 @@
         <Path>..\builds\Toolkit\Channel\Wait for End-of-File.vi</Path>
         <VI_Title>Wait for End-of-File</VI_Title>
       </Items_Data>
-      <Items_Data>
-        <Type>Item</Type>
-        <Sub_Palette_Index>-1</Sub_Palette_Index>
-        <NameSub_Menu_Name>Close.vi</NameSub_Menu_Name>
-        <Short_Name/>
-        <is_Merge_VI>false</is_Merge_VI>
-        <Position>
-          <Row>4</Row>
-          <Column>3</Column>
-        </Position>
-        <Icon>00000000</Icon>
-        <Path>..\builds\Toolkit\Channel\Close.vi</Path>
-        <VI_Title>Close</VI_Title>
-      </Items_Data>
-      <Items_Data>
-        <Type>Item</Type>
-        <Sub_Palette_Index>-1</Sub_Palette_Index>
-        <NameSub_Menu_Name>Wait for Closed.vi</NameSub_Menu_Name>
-        <Short_Name/>
-        <is_Merge_VI>false</is_Merge_VI>
-        <Position>
-          <Row>4</Row>
-          <Column>4</Column>
-        </Position>
-        <Icon>00000000</Icon>
-        <Path>..\builds\Toolkit\Channel\Wait for Closed.vi</Path>
-        <VI_Title>Wait for Closed</VI_Title>
-      </Items_Data>
       <Items_Data>
         <Type>Item</Type>
         <Sub_Palette_Index>-1</Sub_Palette_Index>
@@ -907,7 +883,35 @@
         <Path>..\builds\Toolkit\Channel\Destroy.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>0105222C7B373000164C6B1FE8FD30B1</GUID>
+      <Items_Data>
+        <Type>Item</Type>
+        <Sub_Palette_Index>-1</Sub_Palette_Index>
+        <NameSub_Menu_Name>Wait for Done.vi</NameSub_Menu_Name>
+        <Short_Name/>
+        <is_Merge_VI>false</is_Merge_VI>
+        <Position>
+          <Row>4</Row>
+          <Column>4</Column>
+        </Position>
+        <Icon>00000000</Icon>
+        <Path>..\builds\Toolkit\Channel\Wait for Done.vi</Path>
+        <VI_Title/>
+      </Items_Data>
+      <Items_Data>
+        <Type>Item</Type>
+        <Sub_Palette_Index>-1</Sub_Palette_Index>
+        <NameSub_Menu_Name>Send Done.vi</NameSub_Menu_Name>
+        <Short_Name/>
+        <is_Merge_VI>false</is_Merge_VI>
+        <Position>
+          <Row>4</Row>
+          <Column>3</Column>
+        </Position>
+        <Icon>00000000</Icon>
+        <Path>..\builds\Toolkit\Channel\Send Done.vi</Path>
+        <VI_Title/>
+      </Items_Data>
+      <GUID>6D85C93EA5457305015324C4D37BBC75</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>0</Parent_Palette_Index>
@@ -1082,7 +1086,7 @@
         <Path>..\builds\Toolkit\Session\Write Mode.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>EA674AF82ECAA06EB7799F109052D428</GUID>
+      <GUID>2978987D1458B08A1256A6FD7F3BC0DB</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>0</Parent_Palette_Index>
@@ -1187,7 +1191,7 @@
         <Path>..\builds\Toolkit\SFTP\Destroy.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>7FEA9032974C35C54490654A77EDF725</GUID>
+      <GUID>E67A0DD4E5CF9839B364DBCA6F8E59D1</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>4</Parent_Palette_Index>
@@ -1320,7 +1324,7 @@
         <Path>..\builds\Toolkit\SFTP\Delete File.vi</Path>
         <VI_Title>Delete File</VI_Title>
       </Items_Data>
-      <GUID>F8AC683AFBE6B42C2489B5325FF83900</GUID>
+      <GUID>1B004D56E5CFCD2A796973093804FDEA</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>4</Parent_Palette_Index>
@@ -1509,7 +1513,7 @@
         <Path>..\builds\Toolkit\SFTP File\Write All.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>B6F7A8599CAD62924D8AB10E69BA9F3C</GUID>
+      <GUID>298CB53F802E7C032A750EF3CC1955B4</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>4</Parent_Palette_Index>
@@ -1572,7 +1576,7 @@
         <Path>..\builds\Toolkit\SFTP Directory\Read.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>5F020A0494EEE4BFAD5FED2A00BAE3E6</GUID>
+      <GUID>F4EA690085580E222FFF0DE9B47DFCD6</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>4</Parent_Palette_Index>
@@ -1775,7 +1779,7 @@
         <Path>..\builds\Toolkit\SFTP Attributes\Read File Size.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>72B926B81669A9498D4F8DB410CF8620</GUID>
+      <GUID>32B56E8B547BC4C6F0233D63E5F0C21F</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>0</Parent_Palette_Index>
@@ -1880,7 +1884,7 @@
         <Path>..\builds\Toolkit\File Info\Destroy.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>6233E532A11A1A731468F19EBDB9BA9A</GUID>
+      <GUID>24F0F29E991C924E30614308B237282E</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>0</Parent_Palette_Index>
@@ -1929,7 +1933,7 @@
         <Path>..\builds\Toolkit\API\Known Host\API</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>13CD9121B3F26FB4FB15349E07336D51</GUID>
+      <GUID>37648C60226A4087CE2FE4EC6C25F851</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>10</Parent_Palette_Index>
@@ -2048,7 +2052,7 @@
         <Path>..\builds\Toolkit\Known Hosts\Destroy.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>2AB579AB80734E0F20CF15E426CB5F80</GUID>
+      <GUID>B0D328C9082F71D992FF0DE1FA0E10A5</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>10</Parent_Palette_Index>
@@ -2153,7 +2157,7 @@
         <Path>..\builds\Toolkit\Known Host\Destroy.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>0DC40F63442AD6469B9BBD7E895968B8</GUID>
+      <GUID>25BA6273D9E7DF67C8E952F4981386E4</GUID>
     </Functions_Palette_Data>
     <Functions_Palette_Data>
       <Parent_Palette_Index>0</Parent_Palette_Index>
@@ -2202,7 +2206,7 @@
         <Path>..\builds\Toolkit\Listener\Destroy.vi</Path>
         <VI_Title/>
       </Items_Data>
-      <GUID>D5721B9FBC3BA159B9D4FD81AE4CB943</GUID>
+      <GUID>37611B9E8D7014165F132E80691ED2CC</GUID>
     </Functions_Palette_Data>
   </Library_Palette_Definition>
 </VI_Package_Builder_Settings>
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -13,8 +13,10 @@ All notable changes to this project will be documented in this file, which is wr
 
 ### Changed
 
+- File Upload example VI snippet in the README to use VIs from the install package instead of source code
+- File Upload example VI snippet in the REAMDE to use new VI icons
 - "Channel.lvclass:Wait on Closed.vi" to "Channel.lvclass:Wait on Done.vi" (See #6)
-- "Channel.lvclass:Closed.vi" to "Channel.lvclass:Done.vi" (See #6)
+- "Channel.lvclass:Close.vi" to "Channel.lvclass:Send Done.vi" (See #6)
 - The VI icon for the "Channel.lvclass:Done.vi" (See #6)
 - The VI icon for the "Channel.lvclass:Wait on Done.vi" (See #6)
 - Converting permission to and from bit masks to use Text Ring values instead of constants

diff --git a/src/Examples/Advanced SCP File Upload.vi b/src/Examples/Advanced SCP File Upload.vi
diff --git a/src/Examples/Simple SCP File Upload.vi b/src/Examples/Simple SCP File Upload.vi
diff --git a/src/Scripts/Package.vi b/src/Scripts/Package.vi
diff --git a/src/Toolkit/Channel/Channel.lvclass b/src/Toolkit/Channel/Channel.lvclass
@@ -306,15 +306,6 @@
 		<Property Name="NI.ClassItem.Priority" Type="Int">1</Property>
 		<Property Name="NI.ClassItem.State" Type="Int">1082929680</Property>
 	</Item>
-	<Item Name="Done.vi" Type="VI" URL="../Done.vi">
-		<Property Name="NI.ClassItem.ConnectorPane" Type="Bin">'!#!!!!!!!)!"1!&amp;!!!-!%!!!@````]!!!!"!!%!!!%I!!!!#1!-1#%'=X2B&gt;(6T!!!,1!-!"'.P:'5!!""!-0````]'=W^V=G.F!!!71&amp;!!!Q!!!!%!!AF&amp;=H*P=C"0&gt;81!"!!!!$2!=!!?!!!@$62P&lt;WRL;81O&lt;(:M;7)01WBB&lt;GZF&lt;#ZM&gt;G.M98.T!!N$;'&amp;O&lt;G6M)%^V&gt;!!71&amp;!!!Q!!!!%!!AB&amp;=H*P=C"*&lt;A!!.%"Q!"Y!!"].6'^P&lt;'NJ&gt;#ZM&gt;GRJ9A^$;'&amp;O&lt;G6M,GRW9WRB=X-!#E.I97ZO:7QA37Y!!'%!]!!-!!-!"!!%!!5!"!!%!!1!"!!'!!1!"!!(!Q!!?!!!$1A!!!!!!!!!!!!!$1M!!!!!!!!!!!!!!!!!!!!!!!!+!!!!!!!!!!!!!!!3!!!.!!!!$!!!!!!!!!!!!!!"!!A!!!!!</Property>
-		<Property Name="NI.ClassItem.ExecutionSystem" Type="Int">-1</Property>
-		<Property Name="NI.ClassItem.Flags" Type="Int">0</Property>
-		<Property Name="NI.ClassItem.IsStaticMethod" Type="Bool">true</Property>
-		<Property Name="NI.ClassItem.MethodScope" Type="UInt">1</Property>
-		<Property Name="NI.ClassItem.Priority" Type="Int">1</Property>
-		<Property Name="NI.ClassItem.State" Type="Int">1082401300</Property>
-	</Item>
 	<Item Name="Execute.vi" Type="VI" URL="../Execute.vi">
 		<Property Name="NI.ClassItem.ConnectorPane" Type="Bin">'!#!!!!!!!)!"1!&amp;!!!-!%!!!@````]!!!!"!!%!!!%Y!!!!#A!-1#%'=X2B&gt;(6T!!!,1!-!"'.P:'5!!""!-0````]'=W^V=G.F!!!71&amp;!!!Q!!!!%!!AF&amp;=H*P=C"0&gt;81!"!!!!$2!=!!?!!!@$62P&lt;WRL;81O&lt;(:M;7)01WBB&lt;GZF&lt;#ZM&gt;G.M98.T!!N$;'&amp;O&lt;G6M)%^V&gt;!!71&amp;!!!Q!!!!%!!AB&amp;=H*P=C"*&lt;A!!%%!Q`````Q&gt;$&lt;WVN97ZE!$2!=!!?!!!@$62P&lt;WRL;81O&lt;(:M;7)01WBB&lt;GZF&lt;#ZM&gt;G.M98.T!!J$;'&amp;O&lt;G6M)%FO!!"B!0!!$!!$!!1!"!!&amp;!!1!"!!%!!1!"A!%!!=!#!-!!(A!!!U)!!!!!!!!!!!!!!U,!!!!!!!!!!!!!!!!!!!!!!!!#A!!!!!!!!!1!!!!%A!!$1!!!!Q!!!!!!!!!!!!!!1!*!!!!!!</Property>
 		<Property Name="NI.ClassItem.ExecutionSystem" Type="Int">-1</Property>
@@ -360,6 +351,15 @@
 		<Property Name="NI.ClassItem.Priority" Type="Int">1</Property>
 		<Property Name="NI.ClassItem.State" Type="Int">1107821074</Property>
 	</Item>
+	<Item Name="Send Done.vi" Type="VI" URL="../Send Done.vi">
+		<Property Name="NI.ClassItem.ConnectorPane" Type="Bin">'!#!!!!!!!)!"1!&amp;!!!-!%!!!@````]!!!!"!!%!!!%I!!!!#1!-1#%'=X2B&gt;(6T!!!,1!-!"'.P:'5!!""!-0````]'=W^V=G.F!!!71&amp;!!!Q!!!!%!!AF&amp;=H*P=C"0&gt;81!"!!!!$2!=!!?!!!@$62P&lt;WRL;81O&lt;(:M;7)01WBB&lt;GZF&lt;#ZM&gt;G.M98.T!!N$;'&amp;O&lt;G6M)%^V&gt;!!71&amp;!!!Q!!!!%!!AB&amp;=H*P=C"*&lt;A!!.%"Q!"Y!!"].6'^P&lt;'NJ&gt;#ZM&gt;GRJ9A^$;'&amp;O&lt;G6M,GRW9WRB=X-!#E.I97ZO:7QA37Y!!'%!]!!-!!-!"!!%!!5!"!!%!!1!"!!'!!1!"!!(!Q!!?!!!$1A!!!!!!!!!!!!!$1M!!!!!!!!!!!!!!!!!!!!!!!!+!!!!!!!!!!!!!!!3!!!.!!!!$!!!!!!!!!!!!!!"!!A!!!!!</Property>
+		<Property Name="NI.ClassItem.ExecutionSystem" Type="Int">-1</Property>
+		<Property Name="NI.ClassItem.Flags" Type="Int">0</Property>
+		<Property Name="NI.ClassItem.IsStaticMethod" Type="Bool">true</Property>
+		<Property Name="NI.ClassItem.MethodScope" Type="UInt">1</Property>
+		<Property Name="NI.ClassItem.Priority" Type="Int">1</Property>
+		<Property Name="NI.ClassItem.State" Type="Int">1082401300</Property>
+	</Item>
 	<Item Name="Send End-of-File.vi" Type="VI" URL="../Send End-of-File.vi">
 		<Property Name="NI.ClassItem.ConnectorPane" Type="Bin">'!#!!!!!!!)!"1!&amp;!!!-!%!!!@````]!!!!"!!%!!!%I!!!!#1!-1#%'=X2B&gt;(6T!!!,1!-!"'.P:'5!!""!-0````]'=W^V=G.F!!!71&amp;!!!Q!!!!%!!AF&amp;=H*P=C"0&gt;81!"!!!!$2!=!!?!!!@$62P&lt;WRL;81O&lt;(:M;7)01WBB&lt;GZF&lt;#ZM&gt;G.M98.T!!N$;'&amp;O&lt;G6M)%^V&gt;!!71&amp;!!!Q!!!!%!!AB&amp;=H*P=C"*&lt;A!!.%"Q!"Y!!"].6'^P&lt;'NJ&gt;#ZM&gt;GRJ9A^$;'&amp;O&lt;G6M,GRW9WRB=X-!#E.I97ZO:7QA37Y!!'%!]!!-!!-!"!!%!!5!"!!%!!1!"!!'!!1!"!!(!Q!!?!!!$1A!!!!!!!!!!!!!$1M!!!!!!!!!!!!!!!!!!!!!!!!+!!!!!!!!!!!!!!!3!!!.!!!!$!!!!!!!!!!!!!!"!!A!!!!!</Property>
 		<Property Name="NI.ClassItem.ExecutionSystem" Type="Int">-1</Property>

diff --git a/src/Toolkit/Channel/Done.vi → src/Toolkit/Channel/Send Done.vi b/src/Toolkit/Channel/Done.vi → src/Toolkit/Channel/Send Done.vi
diff --git a/tests/Channel/Close.vi b/tests/Channel/Close.vi
diff --git a/tests/Channel/Wait for Closed.vi b/tests/Channel/Wait for Closed.vi