Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigshift is false by default, should be (integer) 0 #2031

Closed
robertoostenveld opened this issue May 17, 2022 · 0 comments · Fixed by #2042
Closed

trigshift is false by default, should be (integer) 0 #2031

robertoostenveld opened this issue May 17, 2022 · 0 comments · Fixed by #2042

Comments

@robertoostenveld
Copy link
Contributor

Marc triggered (no pun intended) me to look into the code with #2030 and I noticed

trigshift = ft_getopt(varargin, 'trigshift', false); % causes the value of the trigger to be obtained from a sample that is shifted N samples away from the actual flank

which makes the default false rather than 0. I tested the code, false+1 evaluates to 1, just like 0+1, so it does not seem have to have any serious effect.

Nevertheless, the default should be an integer 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants