attribute evals to array exception

figdice · Jul 14, 2015 · 2c147e8 · 2c147e8
1 parent 4ab3c23
commit 2c147e8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/src/figdice/classes/ViewElementTag.php b/src/figdice/classes/ViewElementTag.php
@@ -196,11 +196,7 @@ function buildXMLAttributesString() {
 								else {
 									$message = 'Attribute ' . $attribute . '="' . $value . '" in tag "' . $this->name . '" evaluated to array.';
 									$message = get_class($this) . ': file: ' . $this->currentFile->getFilename() . '(' . $this->xmlLineNumber . '): ' . $message;
-									if(! $this->logger) {
-										$this->logger = LoggerFactory::getLogger(get_class($this));
-									}
-									$this->logger->error($message);
-									throw new Exception($message);
+									throw new RenderingException($this->getTagName(), $this->getCurrentFilename(), $this->getLineNumber(), $message);
 								}
 							}
 

diff --git a/test/FigXmlTest.php b/test/FigXmlTest.php
@@ -298,4 +298,16 @@ public function testWalkOnEmptyGivesNothing()
     $view->loadString($source);
     $this->assertEquals('', $view->render());
   }
+
+  /**
+   * @expectedException \figdice\exceptions\RenderingException
+   */
+  public function testAttributeEvalsToArrayException()
+  {
+    $source = '<xml attr="{myArray}"></xml>';
+    $view = new View();
+    $view->loadString($source);
+    $view->mount('myArray', array(4, 5, 6));
+    $this->assertEquals('dummy', $view->render());
+  }
 }