Made ctdb rule parameterized

figless · Jan 18, 2021 · e743f82 · e743f82
1 parent 1ee2f66
commit e743f82
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/manifests/rules/samba.pp b/manifests/rules/samba.pp
@@ -1,5 +1,7 @@
 # manage in samba/ctdb
-class nftables::rules::samba {
+class nftables::rules::samba (
+  Boolean $ctdb = false,
+) {
   nftables::rule {
     'default_in-netbios_tcp':
       content => 'tcp dport {139,445} accept',
@@ -10,8 +12,10 @@
       content => 'udp dport {137,138} accept',
   }
 
-  nftables::rule {
-    'default_in-ctdb':
-      content => 'tcp dport 4379 accept',
+  if ($ctdb) {
+    nftables::rule {
+      'default_in-ctdb':
+        content => 'tcp dport 4379 accept',
+    }
   }
 }
diff --git a/spec/classes/rules/samba_spec.rb b/spec/classes/rules/samba_spec.rb
@@ -9,6 +9,20 @@
         it { is_expected.to compile }
         it { is_expected.to contain_nftables__rule('default_in-netbios_tcp').with_content('tcp dport {139,445} accept') }
         it { is_expected.to contain_nftables__rule('default_in-netbios_udp').with_content('udp dport {137,138} accept') }
+        it { is_expected.not_to contain_nftables__rule('default_in-ctdb').with_content('tcp dport 4379 accept') }
+      end
+
+      context 'with ctdb set' do
+        let(:params) do
+          {
+            ctdb: true,
+          }
+        end
+
+        it { is_expected.to compile }
+        it { is_expected.to contain_nftables__rule('default_in-netbios_tcp').with_content('tcp dport {139,445} accept') }
+        it { is_expected.to contain_nftables__rule('default_in-netbios_udp').with_content('udp dport {137,138} accept') }
+        it { is_expected.to contain_nftables__rule('default_in-ctdb').with_content('tcp dport 4379 accept') }
       end
     end
   end