printf: handle Array and Map #26
Conversation
|
@fiji-flo hi, any chance to get this PR reviewed? 🥺 |
There was a problem hiding this comment.
Thanks for this PR @flavio
Could you make it behave like golang fmt.Printf (see https://play.golang.org/p/3AR2Vlf7FWc) and remove the regex dependency?
I'll get back to you faster next time. I had some busy weeks.
|
@fiji-flo, sorry for the late response. I was on vacation :) I've updated the PR to address your notes. Note well, the rendering of arrays was already fine (unless I missed something), I fixed the rendering of maps. Once you're happy with the code I can squash the 3 commits into a single one, unless you prefer to merge the branch as it is |
Handle printing of "%v" with Array and Map objects. Obviously this won't cover 100% of the cases, but it's better than nothing :) Signed-off-by: Flavio Castelli <fcastelli@suse.com>
flavio
force-pushed
the
printf-handle-array-and-map
branch
from
76a356b
to
04ec37a
Compare
|
@fiji-flo I've accepted the change, fixed the indentation, ran the tests and then squashed everything into a single commit Thanks for your reviews! |
|
@fiji-flo just out of curiosity, how do you handle release? I wanted to subscribe to release events to get notified about the |
|
I've never automated it. That's on my TODO for all my crates to move this into a github action. But I published it already. I'll move to branches for the |
Handle printing of
%vwith Array and Map objects.Obviously this won't cover 100% of the cases, but it's better than nothing