iframe support #14
iframe support #14
Conversation
@@ -26,6 +26,7 @@ | |||
"test": "grunt qunit" | |||
}, | |||
"devDependencies": { | |||
"grunt": "~0.4.5" | |||
"grunt": "~0.3.17", | |||
"grunt-cli": "~0.1.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing the grunt dependencies so an npm install
will get a working installation. Not related to the PR but necessary for a working build.
var body = document.querySelector("body"); | ||
|
||
// use the passed information to populate the page | ||
body.innerHTML = data.html; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the snippet html to the body. It occurs to me now that there might be a race condition here where the snippet has to make it into the body before DOM ready so that the enhance events and anything else will run.
Demo added to |
…t more adaptable if you don’t have a virtual domain for this project (I don’t).
As @johnbender noted here there may be issues that will be solved by triggering |
We have external projects that depend on the branch. I restored it and them I'm going to fix this in master of those proejcts. |
No description provided.