This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Existing UserAgent test will always pass / user agent sniffing for iOS 8 issues #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 14, 2015 18:47
…that will never all be false
To take a small sample:
!( ua.match( /Android 2\.[1256]/ ) && ua.indexOf( "AppleWebKit") > -1 ) ||
!( w.operamini && ({}).toString.call( w.operamini ) === "[object OperaMini]" )
This will always be true, as it is unlikely that a browser will be BOTH Android 2.0 browser and OperaMini. As a result, this if doesn't actually do anything...
vpstuart
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that there is a giant bug i the big IF in fixedfixed.js. Basically that each item in the condition should be anded together.
I noticed this while addressing an issue in iOS 8 that makes it always fail the scroll test, requiring a userAgent test to avoid.