This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
prevent numeric value navigation with data attr #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.$el.on( "focus", function( e ) { | ||
| self.initMaxlength(); | ||
| }).on( "keypress", function( e ) { | ||
| }).on( "keydown", function( e ) { |
There was a problem hiding this comment.
This makes me nervous and needs at least one other set of eyes.
|
@johnbender - I'll let @zachleat review the JS but I wonder if we could also key this off of the presence of this class which hides the spinner arrows: ...we can also have the data attr there, but if we added support via class this won't require a markup change |
|
LGTM @johnbender! |
|
@johnbender - see my comment above, might wan to add this class trigger as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to prevent numeric value navigation using the keyboard.