Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

Issue with relative path including parent folder #65

Closed
nhoizey opened this issue May 27, 2015 · 3 comments · Fixed by #68
Closed

Issue with relative path including parent folder #65

nhoizey opened this issue May 27, 2015 · 3 comments · Fixed by #68

Comments

@nhoizey
Copy link
Contributor

nhoizey commented May 27, 2015

If the CSS href begins with ../, the indexOf test never returns true, the media attribute keeps the only x value, and the setTimeout goes indefinitely.

This is because the browser translates the relative path to an absolute one, that doesn't contain the ../ part anymore.
@nhoizey
Copy link
Contributor Author

nhoizey commented May 27, 2015

Ok, I just saw there's already a pull request for that: #52

scottjehl added a commit that referenced this issue May 28, 2015
@scottjehl
Allow relative paths to work. Fixes #65
1f97ab0
@scottjehl
Copy link
Member

I think the proposed fix in 1f97ab0 will be a bit more reliable. Thoughts?

@nhoizey
Copy link
Contributor Author

nhoizey commented May 28, 2015

I think so indeed!

scottjehl added a commit that referenced this issue May 28, 2015
@scottjehl
Add unit tests with one failing test that will be fixed when #65 lands.
721931d 
add test harness with 2 passing tests (cherry-picking from commit a66b1fb)
unit test: cssom increments by 1 (cherry-picking from commit f7f6943)
typo (cherry-picking from commit 444eb0a)
unit test: stylesheet successfully loaded (cherry-picking from commit b07aeb1)
add passing tests for all other api features including relative paths (cherry-picking from commit 1e8393d)
test relative paths better, without onload, so it compares paths (cherry-picking from commit b06476d)
add test harness with 2 passing tests (cherry-picking from commit a66b1fb)
unit test: cssom increments by 1 (cherry-picking from commit f7f6943)
typo (cherry-picking from commit 444eb0a)
unit test: stylesheet successfully loaded (cherry-picking from commit b07aeb1)
add passing tests for all other api features including relative paths (cherry-picking from commit 1e8393d)
test relative paths better, without onload, so it compares paths (cherry-picking from commit b06476d)
add test harness with 2 passing tests (cherry-picking from commit a66b1fb)
unit test: cssom increments by 1 (cherry-picking from commit f7f6943)
typo (cherry-picking from commit 444eb0a)
unit test: stylesheet successfully loaded (cherry-picking from commit b07aeb1)
add passing tests for all other api features including relative paths (cherry-picking from commit 1e8393d)
test relative paths better, without onload, so it compares paths (cherry-picking from commit b06476d)
scottjehl added a commit that referenced this issue May 28, 2015
@scottjehl
allow relative paths to work. fixes #65
116b011
@scottjehl scottjehl mentioned this issue May 28, 2015
Merged
zachleat added a commit that referenced this issue Jun 1, 2015
@zachleat
Merge pull request #68 from filamentgroup/fix-65
84739e3 
allow relative paths to work. fixes #65
@jbmoelker jbmoelker mentioned this issue Jul 23, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow relative paths to work. fixes #65 filamentgroup/loadCSS
2 participants
@nhoizey @scottjehl