This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Allows data-tablesaw-no-labels to be added to a <td> #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a scenario where a table had a colum which contained a URL and I didn't need a
URLlabel to be displayed alongside it.A row level
data-tablesaw-no-labelswould remove the labels for everytdin that row and I only needed a label removed for a specifictd.Hence, I tweaked some code to allow a
tdto have its label suppressed.I included a
labelless.htmlpage as an example of what I mean.I'm unfamiliar with QUnit (or js testing frameworks for that matter). Although I'm interested in learning it I don't have the capacity at the moment. I figured this PR was more productive than raising an issue.
It also responds to this issue that was raised previously: #144