refactor

filamentphp · Jun 14, 2024 · 582a2fc · 582a2fc
1 parent 6a8ed61
commit 582a2fc
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 16 deletions.
diff --git a/packages/actions/docs/07-prebuilt-actions/08-import.md b/packages/actions/docs/07-prebuilt-actions/08-import.md
@@ -494,7 +494,7 @@ ImportColumn::make('sku')
     ->example('ABC123')
 ```
 
-Or if you want to add more than one example row, you can pass array to `examples()` method:
+Or if you want to add more than one example row, you can pass an array to the `examples()` method:
 
 ```php
 use Filament\Actions\Imports\ImportColumn;

diff --git a/packages/actions/src/Concerns/CanImportRecords.php b/packages/actions/src/Concerns/CanImportRecords.php
@@ -334,24 +334,26 @@ protected function setUp(): void
                         $columns,
                     ));
 
-                    $rowsCount = array_reduce(
+                    $columnExamples = array_map(
+                        fn (ImportColumn $column): array => $column->getExamples(),
                         $columns,
-                        function (?int $maxCount, ImportColumn $column) {
-                            return max($maxCount, count($column->getExamples()));
-                        },
-                        0
                     );
 
-                    $examples = [];
-                    foreach ($columns as $column) {
-                        $columnExamples = $column->getExamples();
+                    $exampleRowsCount = array_reduce(
+                        $columnExamples,
+                        fn (int $count, array $exampleData): int => max($count, count($exampleData)),
+                        initial: 0,
+                    );
+
+                    $exampleRows = [];
 
-                        for($i = 0; $i < $rowsCount; $i++) {
-                            $examples[$i][] = $columnExamples[$i] ?? '';
+                    foreach ($columnExamples as $exampleData) {
+                        for ($i = 0; $i < $exampleRowsCount; $i++) {
+                            $exampleRows[$i][] = $exampleData[$i] ?? '';
                         }
                     }
 
-                    $csv->insertAll($examples);
+                    $csv->insertAll($exampleRows);
 
                     return response()->streamDownload(function () use ($csv) {
                         echo $csv->toString();

diff --git a/packages/actions/src/Imports/ImportColumn.php b/packages/actions/src/Imports/ImportColumn.php
@@ -119,12 +119,12 @@ public function example(mixed $example): static
         return $this;
     }
 
-    /**
-     * @param mixed $examples
-     */
     public function examples(mixed $examples): static
     {
-        if (!is_array($examples) && !$examples instanceof Closure) {
+        if (
+            (! is_array($examples)) &&
+            (! $examples instanceof Closure)
+        ) {
             $examples = Arr::wrap($examples);
         }