Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supporting to initial audio or video in upload file field #11132

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

sbc640964
Copy link
Contributor

@sbc640964 sbc640964 commented Jan 29, 2024

Add supporting to initial audio or video to upload file

Description

Until now the input could not play sound or video from a default or initial set, from now on it will be able to play them.

Testing

  • Changes have been tested.

Documentation

  • Documentation is up-to-date.

Until now the input could not play sound or video from a default or initial set, from now on it will be able to play them.
@sbc640964 sbc640964 changed the title add-support-initial-video-audio-on-upload-file Add supporting initial audio or video to upload file Jan 29, 2024
@sbc640964 sbc640964 changed the title Add supporting initial audio or video to upload file Add supporting to initial audio or video to upload file Jan 29, 2024
@sbc640964 sbc640964 changed the title Add supporting to initial audio or video to upload file Add supporting to initial audio or video in upload file field Jan 29, 2024
@danharrin danharrin added the bug Something isn't working label Jan 29, 2024
@danharrin danharrin added this to the v3 milestone Jan 29, 2024
@danharrin
Copy link
Member

Can you please compile the assets with npm run build?

@danharrin
Copy link
Member

Did you test this locally?

@sbc640964
Copy link
Contributor Author

Can you please compile the assets with ?npm run build

I got a little confused with this, how do I carry out your request?

@sbc640964
Copy link
Contributor Author

Did you test this locally?

Of course

@danharrin
Copy link
Member

How did you test this locally without compiling the JavaScript?

@sbc640964
Copy link
Contributor Author

How did you test this locally without compiling the JavaScript?

Maybe I don't understand correctly,
When I do npm run build on a laravel project it also compiles laravel app assets, not just the package, am I wrong?

@danharrin
Copy link
Member

You have to download the package repository, npm install and then run the command. What were the steps you took to ensure that this change works?

@sbc640964
Copy link
Contributor Author

sbc640964 commented Jan 31, 2024

You have to download the package repository, npm install and then run the command. What were the steps you took to ensure that this change works?

To testing, I changed a temporary file in the vendor file, I saw that it does work.

OK. Anyway I will follow the rules here.
And then I will compile the assets and push the change, I Hope that I'm understood correctly.

@danharrin
Copy link
Member

Changing this vendor file will not make a difference. To start, it isn't compiled, and secondly, it then needs to be published to /public.

So can you please double check that this is actually a problem that needs this fix?

@danharrin
Copy link
Member

Hey @sbc640964, any updates?

@danharrin danharrin closed this Feb 6, 2024
@danharrin danharrin reopened this Feb 6, 2024
@danharrin
Copy link
Member

I've compiled it for you

@danharrin danharrin merged commit 1fde31a into filamentphp:3.x Feb 8, 2024
6 checks passed
@sbc640964
Copy link
Contributor Author

I've compiled it for you

Thank you!
you are awesome! I'm just busy and haven't found time for it (when I mean I'm also afraid maybe I didn't understand you correctly), anyway after you did it I got the idea, I hope it helps next time... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants