Use new hasActualContent method on slots
#11410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepfietje
requested changes
Feb 17, 2024
There was a problem hiding this comment.
Thanks, @comes!
Could you use the actual method in the Blade components instead of our helper?
Also mark the helper as deprecated please.
Probably we also need to bump the minimum required Laravel version because your method was only introduced recently?
|
@zepfietje our helper allows Htmlable (HtmlStrings and View objects etc) whereas Laravel's is only available on component slots, so I have refactored it to use the new method and keep our helper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Laravel will shortly become a new method for slots
hasActualContent()(see laravel/framework#49966), I think it might be a good idea to use the framework instead of filaments own regex.This PR will update to the new function.