Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSchemaBuilder will return SchemaBuilder not Schema Facade #11604

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

recca0120
Copy link
Contributor

Description

https://github.com/laravel/framework/blob/10.x/src/Illuminate/Database/Connection.php#L317-L324

getSchemaBuilder will return Illuminate\Database\Schema\Builder
截圖 2024-02-28 凌晨4 54 24

Code style

  • composer cs command has been run.

@danharrin
Copy link
Member

The tests are failing as I think the import was being used elsewhere. Have you tested this manually?

@danharrin danharrin added the bug Something isn't working label Feb 28, 2024
@danharrin danharrin added this to the v3 milestone Feb 28, 2024
@danharrin danharrin merged commit 427186f into filamentphp:3.x Feb 28, 2024
10 checks passed
@zepfietje zepfietje linked an issue Feb 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make:filament-resource fails when using the --generate option
2 participants