Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #11977

Merged
merged 5 commits into from Mar 21, 2024
Merged

Update PR template #11977

merged 5 commits into from Mar 21, 2024

Conversation

zepfietje
Copy link
Member

@zepfietje zepfietje commented Mar 21, 2024

Description

This PR makes changes to the PR template to clarify which steps need to be completed. Also, it adds a warning that the PR may be closed if the steps are not followed.

@zepfietje zepfietje added this to the v3 milestone Mar 21, 2024
@zepfietje
Copy link
Member Author

Will need to make this change on the 2.x branch too if merged.

@zepfietje zepfietje changed the title Update pr template Update PR template Mar 21, 2024
This reverts commit 6069e1a.
@zepfietje zepfietje marked this pull request as draft March 21, 2024 12:34
@zepfietje zepfietje marked this pull request as ready for review March 21, 2024 19:48
@zepfietje zepfietje requested review from danharrin and removed request for danharrin March 21, 2024 19:48
@danharrin danharrin merged commit 2979bfd into 3.x Mar 21, 2024
21 checks passed
@danharrin danharrin deleted the update-pr-template branch March 21, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants