Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Rich editor not displaying data when changing languages #11979

Conversation

coleshirley
Copy link
Contributor

Description

closes #11880

The value of the editor is now captured before the nextTick callback as a local variable so that state changes work properly

Code style

  • composer cs command has been run.

Testing

  • Changes have been tested.

Documentation

  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Mar 21, 2024
@danharrin danharrin added this to the v3 milestone Mar 21, 2024
@danharrin danharrin merged commit 59c471d into filamentphp:3.x Mar 21, 2024
10 checks passed
@telkins
Copy link
Contributor

telkins commented Mar 22, 2024

Just seeing this. I'm wondering if there's a similar problem with the markdown editor?

I have noticed issues similar to what I just (quickly) read in the related issue, #11880 , but I haven't had time to put together a test repo.

Any thoughts?

@danharrin
Copy link
Member

See if a similar fix could be implemented and test it?

@telkins
Copy link
Contributor

telkins commented Mar 22, 2024

See if a similar fix could be implemented and test it?

I forked the test repo already and have swapped out the component, but that's as far as I've gotten. I'm at my "day job", so I won't have time until tonight or this weekend....I hope. 😅

Anyway, I'll update when I have/know more.

Thx. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rich editor not displaying data when changing languages
3 participants