Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass target attribute to icon button when button label is hidden at breakpoint #11987

Merged
merged 1 commit into from Mar 22, 2024
Merged

Pass target attribute to icon button when button label is hidden at breakpoint #11987

merged 1 commit into from Mar 22, 2024

Conversation

wallacemaxters
Copy link
Contributor

@wallacemaxters wallacemaxters commented Mar 22, 2024 •
edited

This pull request is a fix for problem described in #11986

Description

Adding the target attribute to <x-filament::button /> component when labeledFrom is passed

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@zepfietje zepfietje linked an issue Mar 22, 2024 that may be closed by this pull request
labeledFrom removes target="_blank" attributes at breakpoint #11986
Closed
@zepfietje zepfietje added the bug Something isn't working label Mar 22, 2024
@zepfietje zepfietje changed the title Pass target attribute when label is hidden at breakpoint Pass target attribute to icon button when label is hidden at breakpoint Mar 22, 2024
@zepfietje zepfietje changed the title Pass target attribute to icon button when label is hidden at breakpoint Pass target attribute to icon button when button label is hidden at breakpoint Mar 22, 2024
@zepfietje zepfietje added this to the v3 milestone Mar 22, 2024
@zepfietje
Copy link
Member

Thanks, @wallacemaxters!
Please make sure to check all checkboxes next time.

@zepfietje zepfietje merged commit fa626b4 into filamentphp:3.x Mar 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Roadmap
Archived in project
Milestone
v3
Development

Successfully merging this pull request may close these issues.

labeledFrom removes target="_blank" attributes at breakpoint
2 participants
@wallacemaxters @zepfietje